KEMBAR78
Support Python `3.11` for AgentIQ by yczhang-nv · Pull Request #148 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Apr 25, 2025

Description

  • Downgrades Python requirement from 3.12 to 3.11 across all packages
  • Adds compatibility layer for typing.override decorator type_utils.py
  • Replaces all @typing.override instances with the compatible version

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@yczhang-nv yczhang-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Apr 25, 2025
@yczhang-nv yczhang-nv self-assigned this Apr 25, 2025
@yczhang-nv yczhang-nv requested a review from a team as a code owner April 25, 2025 19:37
@yczhang-nv yczhang-nv changed the title Support Python 3.11 for AgentIQ Support Python 3.11 for AgentIQ Apr 25, 2025
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
…ython3.11

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
…ython3.11

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Yuchen Zhang <yuchenz@yuchenz-mlt.client.nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@yczhang-nv yczhang-nv force-pushed the yuchen-support-python3.11 branch from f84371d to 7efbacb Compare April 29, 2025 00:33
@yczhang-nv
Copy link
Contributor Author

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 29, 2025

/ok to test

@yczhang-nv, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@yczhang-nv
Copy link
Contributor Author

/ok to test 7efbacb

@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fd7708c into NVIDIA:develop Apr 29, 2025
10 checks passed
mpenn pushed a commit to mpenn/NeMo-Agent-Toolkit that referenced this pull request Apr 29, 2025
- Downgrades Python requirement from `3.12` to `3.11` across all packages
- Adds compatibility layer for `typing.override` decorator `type_utils.py`
- Replaces all `@typing.override` instances with the compatible version

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#148
Signed-off-by: mpenn <mpenn@nvidia.com>
@yczhang-nv yczhang-nv deleted the yuchen-support-python3.11 branch May 6, 2025 21:47
yczhang-nv added a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
- Downgrades Python requirement from `3.12` to `3.11` across all packages
- Adds compatibility layer for `typing.override` decorator `type_utils.py`
- Replaces all `@typing.override` instances with the compatible version

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#148
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
- Downgrades Python requirement from `3.12` to `3.11` across all packages
- Adds compatibility layer for `typing.override` decorator `type_utils.py`
- Replaces all `@typing.override` instances with the compatible version

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#148
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
- Downgrades Python requirement from `3.12` to `3.11` across all packages
- Adds compatibility layer for `typing.override` decorator `type_utils.py`
- Replaces all `@typing.override` instances with the compatible version

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants