KEMBAR78
Adding pytest-pretty for nice test outputs by benomahony · Pull Request #194 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Adding pytest-pretty for nice test outputs #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2025
Merged

Adding pytest-pretty for nice test outputs #194

merged 6 commits into from
May 28, 2025

Conversation

@benomahony
Copy link
Contributor

Description

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@benomahony
Adding pytest-pretty for nice test outputs
547d598 
Signed-off-by: benomahony <bomarni@googlemail.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@benomahony
Copy link
Contributor Author

@mdemoret-nv cleaned up commits + signed

@AnuradhaKaruppiah
Drop unnecessary whitespace changes
eb47bc5 
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
@AnuradhaKaruppiah
Copy link
Contributor

/ok to test eb47bc5

@AnuradhaKaruppiah
Copy link
Contributor

AnuradhaKaruppiah commented May 8, 2025 •
edited
Loading

@benomahony Thanks for the PR.
Please resolve the conflict in uv.lock using the following steps:

git fetch upstream 
git merge upstream/develop
rm uv.lock 
uv sync --all-groups --all-extras
git add uv.lock 
git merge --continue

@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels May 8, 2025
@dagardner-nv dagardner-nv self-assigned this May 16, 2025
@dagardner-nv
Copy link
Contributor

LGTM, on hold for internal approvals

dagardner-nv
dagardner-nv reviewed May 17, 2025
View reviewed changes
@mdemoret-nv
Incorporating feedback
ee6cf56 
Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
@mdemoret-nv
Merge remote-tracking branch 'upstream/develop' into benomahony/develop
996a0c5 
Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
@mdemoret-nv
Updating UV lock
2322037 
Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
@mdemoret-nv
Copy link
Collaborator

/ok to test 2322037

mdemoret-nv
mdemoret-nv approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually pushed these changes to get the PR merged.

@mdemoret-nv
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 7e7b65a into NVIDIA:develop May 28, 2025
12 checks passed
gfreeman-nvidia pushed a commit to gfreeman-nvidia/AIQToolkit that referenced this pull request May 30, 2025
@benomahony @gfreeman-nvidia
Adding pytest-pretty for nice test outputs (NVIDIA#194)
5e3fe26 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@benomahony @ericevans-nv
Adding pytest-pretty for nice test outputs (NVIDIA#194)
29f08ca 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@benomahony @ericevans-nv
Adding pytest-pretty for nice test outputs (NVIDIA#194)
e7f5ad9 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
@benomahony @ericevans-nv
Adding pytest-pretty for nice test outputs (NVIDIA#194)
5334a58 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@benomahony
Adding pytest-pretty for nice test outputs (NVIDIA#194)
faa9368 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@benomahony
Adding pytest-pretty for nice test outputs (NVIDIA#194)
d24d01c 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Ben O'Mahony (https://github.com/benomahony)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dagardner-nv dagardner-nv dagardner-nv left review comments

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benomahony @AnuradhaKaruppiah @dagardner-nv @mdemoret-nv