KEMBAR78
Fix case where res['categories'] = None by balvisio · Pull Request #22 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@balvisio
Copy link
Contributor

@balvisio balvisio commented Mar 19, 2025

@mdemoret-nv res sometimes contains the categories field =None

Causing a pydantic validation exception sometimes

@dnandakumar-nv
Copy link
Contributor

@balvisio before we can merge this, we need DCO checks to pass. You can find more info about this here: https://github.com/NVIDIA/AgentIQ/pull/22/checks?check_run_id=39071169962

Signed-off-by: Bruno Alvisio <balvisio@nvidia.com>
@balvisio balvisio requested a review from a team as a code owner April 1, 2025 14:31
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balvisio
Copy link
Contributor Author

balvisio commented Apr 1, 2025

@dnandakumar-nv fixed

@dnandakumar-nv dnandakumar-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 1, 2025
@dnandakumar-nv
Copy link
Contributor

/ok to test

@dnandakumar-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit b1a3c23 into NVIDIA:develop Apr 1, 2025
9 checks passed
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request Apr 2, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 14, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request Apr 21, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@mdemoret-nv `res` sometimes contains the `categories` field `=None`

Causing a pydantic validation exception sometimes

Authors:
  - Bruno Alvisio (https://github.com/balvisio)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants