KEMBAR78
feat(telemetry): add langfuse and langsmith telemetry exporters #233 by briancaffey · Pull Request #235 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@briancaffey
Copy link
Contributor

Description

add langfuse and langsmith telemetry exporters with examples

Closes #233

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…A#233

Signed-off-by: Brian Caffey <briancaffey2010@gmail.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented May 9, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from Copilot May 9, 2025 18:01
@AnuradhaKaruppiah AnuradhaKaruppiah added feature request New feature or request non-breaking Non-breaking change labels May 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new telemetry exporters for Langfuse and Langsmith, enabling the transmission of traces to these external services with example configurations.

  • Introduces LangfuseTelemetryExporter and LangsmithTelemetryExporter in the observability module.
  • Updates the registration logic and YAML configuration samples for both exporters.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/aiq/observability/register.py Added new telemetry exporter classes and updated logging for Phoenix exporter.
examples/simple_calculator/src/aiq_simple_calculator/configs/config-langsmith.yml Added example configuration for the Langsmith exporter.
examples/simple_calculator/src/aiq_simple_calculator/configs/config-langfuse.yml Added example configuration for the Langfuse exporter.

@AnuradhaKaruppiah
Copy link
Contributor

/ok to test f391c84

@mdemoret-nv
Copy link
Collaborator

/ok to test 5da3813

@mdemoret-nv mdemoret-nv requested a review from Copilot May 29, 2025 00:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Langfuse and Langsmith telemetry exporters to the AIQ observability module, allowing users to transmit tracing data to these external services. It introduces the exporter classes and registration logic in the core observability module, provides example configuration files for both exporters, and updates the documentation to describe their usage.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/aiq/observability/register.py Added new telemetry exporter classes and registration functions for Langfuse and Langsmith.
examples/simple_calculator/src/aiq_simple_calculator/configs/config-langsmith.yml Added an example configuration for the Langsmith telemetry exporter.
examples/simple_calculator/src/aiq_simple_calculator/configs/config-langfuse.yml Added an example configuration for the Langfuse telemetry exporter.
docs/source/workflows/observe/index.md Updated the documentation to include configuration details for the new telemetry exporters.

Copy link
Collaborator

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added docs while reviewing. Looks good. Thanks for the contribution!

Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
@mdemoret-nv
Copy link
Collaborator

/ok to test 8f1b689

@mdemoret-nv
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit fd9316a into NVIDIA:develop May 29, 2025
12 checks passed
gfreeman-nvidia pushed a commit to gfreeman-nvidia/AIQToolkit that referenced this pull request May 30, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Jun 3, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
…A#233 (NVIDIA#235)

add langfuse and langsmith telemetry exporters with examples

Closes NVIDIA#233

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - briancaffey (https://github.com/briancaffey)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA]: Add Langsmith and Langfuse telemetry exporters

3 participants