-
Notifications
You must be signed in to change notification settings - Fork 396
feat(telemetry): add langfuse and langsmith telemetry exporters #233 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): add langfuse and langsmith telemetry exporters #233 #235
Conversation
…A#233 Signed-off-by: Brian Caffey <briancaffey2010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds two new telemetry exporters for Langfuse and Langsmith, enabling the transmission of traces to these external services with example configurations.
- Introduces LangfuseTelemetryExporter and LangsmithTelemetryExporter in the observability module.
- Updates the registration logic and YAML configuration samples for both exporters.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aiq/observability/register.py | Added new telemetry exporter classes and updated logging for Phoenix exporter. |
| examples/simple_calculator/src/aiq_simple_calculator/configs/config-langsmith.yml | Added example configuration for the Langsmith exporter. |
| examples/simple_calculator/src/aiq_simple_calculator/configs/config-langfuse.yml | Added example configuration for the Langfuse exporter. |
|
/ok to test f391c84 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: briancaffey <briancaffey2010@gmail.com>
Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
|
/ok to test 5da3813 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Langfuse and Langsmith telemetry exporters to the AIQ observability module, allowing users to transmit tracing data to these external services. It introduces the exporter classes and registration logic in the core observability module, provides example configuration files for both exporters, and updates the documentation to describe their usage.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aiq/observability/register.py | Added new telemetry exporter classes and registration functions for Langfuse and Langsmith. |
| examples/simple_calculator/src/aiq_simple_calculator/configs/config-langsmith.yml | Added an example configuration for the Langsmith telemetry exporter. |
| examples/simple_calculator/src/aiq_simple_calculator/configs/config-langfuse.yml | Added an example configuration for the Langfuse telemetry exporter. |
| docs/source/workflows/observe/index.md | Updated the documentation to include configuration details for the new telemetry exporters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added docs while reviewing. Looks good. Thanks for the contribution!
Signed-off-by: Michael Demoret <mdemoret@nvidia.com>
|
/ok to test 8f1b689 |
|
/merge |
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235 Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235
…A#233 (NVIDIA#235) add langfuse and langsmith telemetry exporters with examples Closes NVIDIA#233 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#235
Description
add langfuse and langsmith telemetry exporters with examples
Closes #233
By Submitting this PR I confirm: