Move Wikipedia search to separate file #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Kornblum <jkornblum@nvidia.com>
jkornblum-nv
force-pushed
the
jkornblum-nv-wikipedia-search
branch
from
d87dc2e to
504d902
Compare
yczhang-nv
added
improvement
|
/ok to test 8e2ae2e |
AnuradhaKaruppiah
approved these changes
May 20, 2025
There was a problem hiding this comment.
Pull Request Overview
Moves the Wikipedia search tool out of the Tavily internet search module into its own file and updates the registration to include the new module.
- Extracts the
wiki_searchtool intowikipedia_search.py - Removes duplicated Wikipedia code from
tavily_internet_search.py - Updates
register.pyto import the standalone Wikipedia tool
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/wikipedia_search.py | New file defining the standalone Wikipedia search tool |
| packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/tavily_internet_search.py | Removed embedded Wikipedia code block |
| packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/register.py | Added import for the new wikipedia_search module |
Comments suppressed due to low confidence (2)
packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/wikipedia_search.py:22
- This new standalone tool implementation should be covered by unit or integration tests to ensure its behavior (e.g., max_results handling) stays correct.
class WikiSearchToolConfig(FunctionBaseConfig, name="wiki_search"):
packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/wikipedia_search.py:46
- [nitpick] The multi-line description string is indented with extra spaces, which will appear in the generated help text; consider dedenting or using
textwrap.dedentto keep the description clean.
description=("""This tool retrieves relevant contexts from wikipedia search for the given question.
packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/wikipedia_search.py
Show resolved
Hide resolved
packages/aiqtoolkit_langchain/src/aiq/plugins/langchain/tools/register.py
Show resolved
Hide resolved
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
|
/ok to test 232a50f |
@AnuradhaKaruppiah, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 3c28c81 |
|
/merge |
gfreeman-nvidia
pushed a commit
to gfreeman-nvidia/AIQToolkit
that referenced
this pull request
May 30, 2025
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#237 Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#237 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#237 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#237
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
Moves the Wikipedia search tool to a separate file. It had been included with Tavily. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Jesse Kornblum (https://github.com/jkornblum-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the Wikipedia search tool to a separate file. It had been included with Tavily.
By Submitting this PR I confirm: