Add a pyproject.toml to simple_rag example allowing for declared dependencies
#284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lxml, langchain, and mem0ai Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv
added
improvement
dagardner-nv
changed the title
pyproject.toml allowing the example to declare dependencies on lxml, langchain, and mem0aipyproject.toml to simple_rag example allowing for declared dependencies
…r examples, add an optional 'ingestion' dependency group to declare an explicit dependency on lxml (currently a transitory dep) Signed-off-by: David Gardner <dagardner@nvidia.com>
…ntation recomends running from the root which creates a data dir at the root which is not ignored Signed-off-by: David Gardner <dagardner@nvidia.com>
…e logs Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ple-rag-project-239 Signed-off-by: David Gardner <dagardner@nvidia.com>
…ple-rag-project-239 Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
2 tasks
yczhang-nv
approved these changes
May 20, 2025
|
/merge |
gfreeman-nvidia
pushed a commit
to gfreeman-nvidia/AIQToolkit
that referenced
this pull request
May 30, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284 Signed-off-by: Greg Freeman <gfreeman@nvidia.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284 Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
…dependencies (NVIDIA#284) * Add a `pyproject.toml` to `simple_rag`. * While this example does not contain any custom components needing to be installed, it does require dependencies (langchain, mem0ai and lxml). * Create a new optional `ingestion` dependency group, declaring a dependency on `lxml`, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with the `langchain_web_ingest.py` script. * Move ingestion scripts from the `simple_rag` example to the `scripts` dir as this script is used by another example. * Change the default output dir for `langchain_web_ingest.py` to `.tmp/data`, when run as documented this created a `data` dir at the root of the repo which was not ignored by git. * Fix incorrect command output in the `automated_description_generation` example Closes NVIDIA#239 Closes NVIDIA#241 Closes NVIDIA#224 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: NVIDIA#284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
pyproject.tomltosimple_rag.Create a new optional
ingestiondependency group, declaring a dependency onlxml, currently this is a transitory dependency, this adds an explicit dependency on a version known to be compatible with thelangchain_web_ingest.pyscript.Move ingestion scripts from the
simple_ragexample to thescriptsdir as this script is used by another example.Change the default output dir for
langchain_web_ingest.pyto.tmp/data, when run as documented this created adatadir at the root of the repo which was not ignored by git.Fix incorrect command output in the
automated_description_generationexampleCloses #239
Closes #241
Closes #224
By Submitting this PR I confirm: