Fix: #32 Recursion Issue #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atalhens <sneh.lata@nutanix.com>
|
@sean-javiya-nvidia Can you review these changes? |
Signed-off-by: atalhens <sneh.lata@nutanix.com>
|
Awesome! Thanks for quickly addressing @atalhens! The last suggestion I have, could we add a unit test for the added improvement? we could maybe add a unit test here, maybe something like this that way, we can ensure any future contributions or changes don't accidentally change the desired behavior |
Signed-off-by: atalhens <sneh.lata@nutanix.com>
mdemoret-nv
approved these changes
Mar 26, 2025
|
Added unit test, Thanks for your suggestion @sean-javiya-nvidia! Let me know if it addresses your concern :) |
|
@atalhens Thanks for your contribution! |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 14, 2025
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
Apr 21, 2025
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com>
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
* Fix NVIDIA#32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On observing the way, the agent executes the question received from the user: https://github.com/NVIDIA/AgentIQ/blob/develop/src/aiq/agent/react_agent/agent.py#L108.
Looks like there is no sanity check if the input query received from the user side is valid or not.
Edit added to check is the input is like "", " " [empty or blank spaces].
Output will be shown as No human input provided.
Closes #32