Fix AttributeError bug for otel_telemetry_exporter #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhongxuanwang <cndanielwang@gmail.com>
Signed-off-by: zhongxuanwang <cndanielwang@gmail.com>
mdemoret-nv
approved these changes
Jun 6, 2025
|
/ok to test 68434ca |
|
/ok to test aff0ae1 |
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
Closes NVIDIA#320 The `otel_telemetry_exporter` function was changed to resolve a potential `AttributeError`. The previous implementation used a class that is not found in the OpenTelemetry's submodule. I've also tried the tracing tool `otelcol` that I made sure can invoke this method explicitly, and after the change it seems that it's working fine. The reason I used the HTTP-based OTLP exporter here is previous examples (`Langfuse` and `Langsmith`) all used the HTTP-based OTLP explicitly. HTTP should also be more broadly accepted and compatible in this case. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Zhongxuan (Daniel) Wang (https://github.com/ZhongxuanWang) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#335
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
Closes NVIDIA#320 The `otel_telemetry_exporter` function was changed to resolve a potential `AttributeError`. The previous implementation used a class that is not found in the OpenTelemetry's submodule. I've also tried the tracing tool `otelcol` that I made sure can invoke this method explicitly, and after the change it seems that it's working fine. The reason I used the HTTP-based OTLP exporter here is previous examples (`Langfuse` and `Langsmith`) all used the HTTP-based OTLP explicitly. HTTP should also be more broadly accepted and compatible in this case. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Zhongxuan (Daniel) Wang (https://github.com/ZhongxuanWang) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #320
The
otel_telemetry_exporterfunction was changed to resolve a potentialAttributeError. The previous implementation used a class that is not found in the OpenTelemetry's submodule.I've also tried the tracing tool
otelcolthat I made sure can invoke this method explicitly, and after the change it seems that it's working fine.The reason I used the HTTP-based OTLP exporter here is previous examples (
LangfuseandLangsmith) all used the HTTP-based OTLP explicitly. HTTP should also be more broadly accepted and compatible in this case.By Submitting this PR I confirm: