KEMBAR78
Add Patronus OTEL Exporter by hersheybar · Pull Request #341 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@hersheybar
Copy link
Contributor

Description

Allow AIQToolkit agentic traces to export logs to the Patronus AI backend. Update the 'simple_calculator' example with a config file which talks to the Patronus endpoint.

Closes #340

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hersheybar hersheybar marked this pull request as draft June 6, 2025 20:54
@hersheybar hersheybar marked this pull request as ready for review June 6, 2025 20:54
@mdemoret-nv mdemoret-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Jun 6, 2025
@mdemoret-nv
Copy link
Collaborator

@hersheybar Can you fix the DCO check so we can get this merged?

Allow AIQToolkit agentic traces to export logs to the Patronus AI backend.
Update the 'simple_calculator' example with a config file which talks to the Patronus endpoint.

Signed-off-by: Hersh Mehta <hersh@patronus.ai>
@hersheybar hersheybar force-pushed the patronus_integration branch from 7e014df to 5a93aa6 Compare June 10, 2025 17:42
@hersheybar
Copy link
Contributor Author

Hello @mdemoret-nv :
I believe the DCO check is now fixed. Please take a look once you have a moment.

@mdemoret-nv
Copy link
Collaborator

@hersheybar Thanks for the updates. DCO is now passing. Would you mind enabling contributions to your PR from maintainers so I can update the docs to match in a single PR? Just need to select this option on the PR:
image

@hersheybar
Copy link
Contributor Author

@mdemoret-nv : I do not see that checkbox anywhere (at the bottom, or on the right hand side tab).
Perplexity says it should be on the right sidebar. However my sidebar has no editable fields
image

Note that the string: "Allow edits and acess..." also doesn't appear on the page source.

Am I missing something?

@mdemoret-nv
Copy link
Collaborator

Im not sure what is going on. I'll just make the docs updates in a second PR and merge this one.

@hersheybar
Copy link
Contributor Author

Awesome, thanks @mdemoret-nv for the quick responses!
I assume you have the permissions to both approve and press the merge button :)

@mdemoret-nv
Copy link
Collaborator

Yes. One second. Need to rerun CI after each commit.

Copy link
Collaborator

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update docs in a second PR

@mdemoret-nv
Copy link
Collaborator

/ok to test 283e454

@hersheybar
Copy link
Contributor Author

Looks like we've been stuck on the pr-builder step for ~24 hours. Is it suppose to take that long @mdemoret-nv ?

@mdemoret-nv
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit c5524a5 into NVIDIA:develop Jun 12, 2025
12 checks passed
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
Allow AIQToolkit agentic traces to export logs to the Patronus AI backend. Update the 'simple_calculator' example with a config file which talks to the Patronus endpoint.




Closes NVIDIA#340 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hersh Mehta (https://github.com/hersheybar)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#341
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
Allow AIQToolkit agentic traces to export logs to the Patronus AI backend. Update the 'simple_calculator' example with a config file which talks to the Patronus endpoint.




Closes NVIDIA#340 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Hersh Mehta (https://github.com/hersheybar)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: NVIDIA#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA]: Update AIQ Observability to support Patronus AI backend

2 participants