KEMBAR78
Rename test mode to offline mode by hsin-c · Pull Request #343 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@hsin-c
Copy link
Contributor

@hsin-c hsin-c commented Jun 6, 2025

This PR renames the test mode of the alert triage agent example to "offline mode" to more accurately reflect its ability to run the full example using an offline dataset, not just for testing purposes.

Testing:

  • All unit tests passed
  • E2e test passed
  • Run offline mode, and the output is as expected

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@AnuradhaKaruppiah
Copy link
Contributor

/ok to test 14e4934

@AnuradhaKaruppiah AnuradhaKaruppiah added improvement Improvement to existing functionality non-breaking Non-breaking change labels Jun 6, 2025
@AnuradhaKaruppiah AnuradhaKaruppiah force-pushed the hsinc-ata-rename-test-mode branch from 14e4934 to 73c4b17 Compare June 6, 2025 00:36
hsin-c and others added 3 commits June 5, 2025 17:38
Signed-off-by: Hsin Chen <hsinc@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
@AnuradhaKaruppiah AnuradhaKaruppiah force-pushed the hsinc-ata-rename-test-mode branch from 73c4b17 to c5ef22e Compare June 6, 2025 00:38
@AnuradhaKaruppiah
Copy link
Contributor

/ok to test c5ef22e

@AnuradhaKaruppiah
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a012244 into NVIDIA:develop Jun 6, 2025
12 checks passed
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
This PR renames the test mode of the alert triage agent example to "offline mode" to more accurately reflect its ability to run the full example using an offline dataset, not just for testing purposes.

Testing:
- All unit tests passed
- E2e test passed
- Run offline mode, and the output is as expected

Authors:
  - https://github.com/hsin-c
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#343
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
This PR renames the test mode of the alert triage agent example to "offline mode" to more accurately reflect its ability to run the full example using an offline dataset, not just for testing purposes.

Testing:
- All unit tests passed
- E2e test passed
- Run offline mode, and the output is as expected

Authors:
  - https://github.com/hsin-c
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants