Simplify offline mode with aiq eval
#344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hsin Chen <hsinc@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
|
/ok to test a5f09c7 |
AnuradhaKaruppiah
added
improvement
AnuradhaKaruppiah
approved these changes
Jun 6, 2025
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
The PR updates the operation in `offline_mode` to leverage `aiq eval` instead of doing a manual iteration of the test dataframe. This increases the efficiency of the run and also adds evaluation benefits to the example. Authors: - https://github.com/hsin-c - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#344
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
The PR updates the operation in `offline_mode` to leverage `aiq eval` instead of doing a manual iteration of the test dataframe. This increases the efficiency of the run and also adds evaluation benefits to the example. Authors: - https://github.com/hsin-c - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the operation in
offline_modeto leverageaiq evalinstead of doing a manual iteration of the test dataframe. This increases the efficiency of the run and also adds evaluation benefits to the example.