-
Notifications
You must be signed in to change notification settings - Fork 396
fix mcp client schema creation in flat lists #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Lopp <slopp@nvidia.com>
|
/ok to test 96cbad1 |
|
/ok to test 45d245f |
AnuradhaKaruppiah
approved these changes
Jun 6, 2025
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
For MCP tools that have an input that is a flat list, eg
```
{
'items': ['item', 'item']
}
```
The original code led to an invalid pydantic schema like this:
```
{
'items': {'items': {}, 'type': 'array'},
'type': 'array'
}
```
Now the schema is correctly created like this:
```
{
'items': {'type': 'string'},
'type': 'array'
}
```
Confirmed the fix using a JIRA MCP tool.
Closes NVIDIA#342
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Sean Lopp (https://github.com/slopp)
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
Approvers:
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
URL: NVIDIA#346
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
For MCP tools that have an input that is a flat list, eg
```
{
'items': ['item', 'item']
}
```
The original code led to an invalid pydantic schema like this:
```
{
'items': {'items': {}, 'type': 'array'},
'type': 'array'
}
```
Now the schema is correctly created like this:
```
{
'items': {'type': 'string'},
'type': 'array'
}
```
Confirmed the fix using a JIRA MCP tool.
Closes NVIDIA#342
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- Sean Lopp (https://github.com/slopp)
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
Approvers:
- Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
URL: NVIDIA#346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MCP tools that have an input that is a flat list, eg
The original code led to an invalid pydantic schema like this:
Now the schema is correctly created like this:
Confirmed the fix using a JIRA MCP tool.
Closes #342
By Submitting this PR I confirm: