fix(phoenix): set project name when using phoenix telemetry exporter (#337) #347
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
approved these changes
Jun 6, 2025
|
@briancaffey Can you do a force push to fix the DCO check and we can get this merged. Thanks! |
…VIDIA#337) Signed-off-by: Brian Caffey <briancaffey2010@gmail.com>
|
/ok to test 4289c41 |
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
…VIDIA#337) (NVIDIA#347) Closes NVIDIA#337 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#347
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
…VIDIA#337) (NVIDIA#347) Closes NVIDIA#337 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - briancaffey (https://github.com/briancaffey) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fix for the Phoenix telemetry exporter. Currently it does not use the project name in the configuration. For Phoenix this needs to be set in the TraceProvider like so:
where
ResourceAttributes.PROJECT_NAMEisopeninference.project.name.This allows for traces to be sent to projects other than the default project:
This also fixes a typo in the Langsmith telemetry exporter that allows for traces to go to the correct project. (header changed from
LANGSMITH_PROJECTtoLangsmith-Project)Langsmith and Langfuse set their
projectdifferently: Langsmith uses a header value (Langsmith-Projectand Langfuse uses per-project keys.This could be problematic if other telemetry exporters also relied on
attributesin theTracerProviderto set the project value. It would also not work if there were multipletelemetry.tracingconfigurations using phoenix defined in a config file. So this might not be an ideal solution, but it should work for simple configurations where you want to use different projects for different configuration files with phoenix.Description
Closes #337
By Submitting this PR I confirm: