Extend IntermediateStep to support tool schemas in tool calling LLM requests
#357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s like tool call information Signed-off-by: Matthew Penn <mpenn@nvidia.com>
…observability-support
…implement a merge function for dictionaries in AsyncOtelSpanListener. This allows for enhanced metadata handling in telemetry spans, Signed-off-by: Matthew Penn <mpenn@nvidia.com>
…implement a merge function for dictionaries in AsyncOtelSpanListener. This allows for enhanced metadata handling in telemetry spans, ensuring non-null values are prioritized when merging metadata attributes. Signed-off-by: Matthew Penn <mpenn@nvidia.com>
…observability-support
Signed-off-by: Matthew Penn <mpenn@nvidia.com>
Signed-off-by: Matthew Penn <mpenn@nvidia.com>
mpenn
changed the title
IntermediateStep to support tool schemas in tool calling LLM requests
Signed-off-by: Matthew Penn <mpenn@nvidia.com>
dnandakumar-nv
added
improvement
dnandakumar-nv
approved these changes
Jun 10, 2025
|
/ok to test 1776839 |
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
… requests (NVIDIA#357) Closes NVIDIA#356 This PR extends the `IntermediateStep` data structure with additional `TraceMetadata` attributes that represent tool calling metadata in a tool calling LLM request. The `TraceMetadata` now includes a `tools_schema` attribute that maps to the OpenAI spec for function calling. In addition, the `LangchainProfilerHander` has been extended to populate this new metadata attribute. Finally, the `AsyncOtelSpanListener` has been extended to include the `IntermediateStep.metadata` attribute in OTel spans. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Penn (https://github.com/mpenn) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#357
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
… requests (NVIDIA#357) Closes NVIDIA#356 This PR extends the `IntermediateStep` data structure with additional `TraceMetadata` attributes that represent tool calling metadata in a tool calling LLM request. The `TraceMetadata` now includes a `tools_schema` attribute that maps to the OpenAI spec for function calling. In addition, the `LangchainProfilerHander` has been extended to populate this new metadata attribute. Finally, the `AsyncOtelSpanListener` has been extended to include the `IntermediateStep.metadata` attribute in OTel spans. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Penn (https://github.com/mpenn) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: NVIDIA#357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #356
This PR extends the
IntermediateStepdata structure with additionalTraceMetadataattributes that represent tool calling metadata in a tool calling LLM request. TheTraceMetadatanow includes atools_schemaattribute that maps to the OpenAI spec for function calling.In addition, the
LangchainProfilerHanderhas been extended to populate this new metadata attribute.Finally, the
AsyncOtelSpanListenerhas been extended to include theIntermediateStep.metadataattribute in OTel spans.By Submitting this PR I confirm: