KEMBAR78
added Agno integration by wenqiglantz · Pull Request #36 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

added Agno integration #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Apr 16, 2025
Merged

added Agno integration #36

merged 24 commits into from
Apr 16, 2025

Conversation

@wenqiglantz
Copy link
Contributor

Changes included in this PR:

  • added Agno package
  • added agno_personal_finance workflow

@mdemoret-nv
Copy link
Collaborator

@dnandakumar-nv To review Monday.

@mdemoret-nv
Copy link
Collaborator

@wenqiglantz Before we can get this merged, we will need the DCO check to pass. You can find more info about this here: https://github.com/NVIDIA/AgentIQ/pull/36/checks?check_run_id=39465660296

@wenqiglantz
added Agno integration
63a3764 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
updated llm.py in Agno package
cf4a4d9 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
dnandakumar-nv
dnandakumar-nv requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, @wenqiglantz ! The additions look great and I'm sure adding support for the Agno package will be valuable. I did have a few comments during the review that I'm hoping we can address to get this merged.

Additionally, I think increased unit testing in the following two areas would be beneficial:

  1. Unit tests in the agentiq_agno package for the tool and llm wrappers to ensure they build correctly in a few different cases. You can find an example of tests here and here
  2. Unit tests for the agno_callback_handler to ensure events are being captured and traced correctly. You can find examples here.

@dnandakumar-nv dnandakumar-nv added enhancement non-breaking Non-breaking change improvement Improvement to existing functionality and removed enhancement labels Mar 31, 2025
@wenqiglantz
fixes per review comments
d0cdbb0 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
fixes per review comments
cb2adeb 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
fixes per review comments
6ffe97f 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz wenqiglantz requested a review from a team as a code owner April 1, 2025 18:34
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wenqiglantz
fixes per review comments
5940cd9 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@dnandakumar-nv
Copy link
Contributor

/ok to test

dnandakumar-nv
dnandakumar-nv approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@dnandakumar-nv
Copy link
Contributor

/ok to test

dnandakumar-nv
dnandakumar-nv requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenqiglantz thanks for your changes! The code looks good to me now, but we need the CI to pass before a merge into the repo. Looks like some of the CI is failing due to the lack of copyright headers:

https://github.com/NVIDIA/AgentIQ/actions/runs/14224833050/job/39861721846?pr=36

@wenqiglantz
fix pylint issue
4affa90 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
Merge branch 'develop' of https://github.com/wenqiglantz/AgentIQ into…
e8b40b6 
… develop
@dnandakumar-nv
Copy link
Contributor

/ok to test

@wenqiglantz
fix CI check warning
54e788a 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
fix CI check warning
2eb6ea7 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@dnandakumar-nv
Copy link
Contributor

/ok to test

@wenqiglantz
fix CI error
8573853 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
Merge remote-tracking branch 'upstream/develop' into develop
65e3d05
@wenqiglantz
added kwargs in accept.txt
87e727f 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
updated tests
70956b8 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
dnandakumar-nv
dnandakumar-nv reviewed Apr 7, 2025
View reviewed changes
@wenqiglantz
updated uv.lock
395100a 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@wenqiglantz
updated tests
fcf4814 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@dnandakumar-nv
Copy link
Contributor

/ok to test

dnandakumar-nv
dnandakumar-nv requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking almost ready! Just a couple minor comments. Thanks for your patience!

@wenqiglantz
updates per review comments
6fc9b2a 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
@dnandakumar-nv
Copy link
Contributor

/ok to test

@dnandakumar-nv
Copy link
Contributor

@wenqiglantz looks like we've got a merge conflict. Ostensibly because the framework wrappers decorator has now moved to aiq.profiler.decorators. Would you mind resolving the conflict?

dnandakumar-nv
dnandakumar-nv approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dnandakumar-nv
Copy link
Contributor

/ok to test 00221bd

dnandakumar-nv
dnandakumar-nv requested changes Apr 16, 2025
View reviewed changes
@wenqiglantz
renamed workflow to aiq_agno_personal_finance
fd7b093 
Signed-off-by: Wenqi Glantz <wglantz@nvidia.com>
dnandakumar-nv
dnandakumar-nv approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@dnandakumar-nv dnandakumar-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnandakumar-nv
Copy link
Contributor

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 16, 2025

/ok to test

@dnandakumar-nv, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@dnandakumar-nv
Copy link
Contributor

/ok to test fd7b093

@dnandakumar-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a8a2a74 into NVIDIA:develop Apr 16, 2025
10 checks passed
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 23, 2025
@wenqiglantz @ericevans-nv
added Agno integration (NVIDIA#36)
8316fac 
Changes included in this PR:

- added Agno package
- added agno_personal_finance workflow

Authors:
  - Wenqi Glantz (https://github.com/wenqiglantz)
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

URL: NVIDIA#36
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 23, 2025
@wenqiglantz @ericevans-nv
added Agno integration (NVIDIA#36)
6cfd49a 
Changes included in this PR:

- added Agno package
- added agno_personal_finance workflow

Authors:
  - Wenqi Glantz (https://github.com/wenqiglantz)
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

URL: NVIDIA#36
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
@mdemoret-nv mdemoret-nv mentioned this pull request Apr 30, 2025
Open
2 tasks
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@wenqiglantz @yczhang-nv
added Agno integration (NVIDIA#36)
9a821ab 
Changes included in this PR:

- added Agno package
- added agno_personal_finance workflow

Authors:
  - Wenqi Glantz (https://github.com/wenqiglantz)
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

URL: NVIDIA#36
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@wenqiglantz
added Agno integration (NVIDIA#36)
0026b0f 
Changes included in this PR:

- added Agno package
- added agno_personal_finance workflow

Authors:
  - Wenqi Glantz (https://github.com/wenqiglantz)
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

URL: NVIDIA#36
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@wenqiglantz
added Agno integration (NVIDIA#36)
f4c3a6d 
Changes included in this PR:

- added Agno package
- added agno_personal_finance workflow

Authors:
  - Wenqi Glantz (https://github.com/wenqiglantz)
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

Approvers:
  - Dhruv Nandakumar (https://github.com/dnandakumar-nv)

URL: NVIDIA#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnandakumar-nv dnandakumar-nv dnandakumar-nv approved these changes

Assignees

No one assigned

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenqiglantz @mdemoret-nv @dnandakumar-nv