add support for union types in mcp client #372
Merged
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Riel <priel@nvidia.com>
mdemoret-nv
added
improvement
|
@cheese-head Looks like a good addition. Let us know when its ready to review. @AnuradhaKaruppiah please review when ready. |
|
/ok to test 256698f |
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Patrick Riel <priel@nvidia.com>
|
I've also added an additional filter for removing None values when making a tool call. ------------------------------
[AGENT]
Agent input: show me a list of issues for '184911'
Agent's thoughts:
Thought: It seems like there's still an error. I'll try to simplify the request.
Action: list_issues
Action Input: {"project_id": "184911"}
------------------------------
{'project_id': '184911', 'assignee_id': None, 'assignee_username': None, 'author_id': None, 'author_username': None, 'confidential': None, 'created_after': None, 'created_before': None, 'due_date': None, 'labels': None, 'milestone': None, 'scope': None, 'search': None, 'state': None, 'updated_after': None, 'updated_before': None, 'with_labels_details': None, 'page': None, 'per_page': None}Should now be ------------------------------
[AGENT]
Agent input: show me a list of issues for '184911'
Agent's thoughts:
Thought: It seems like there's still an error. I'll try to simplify the request.
Action: list_issues
Action Input: {"project_id": "184911"}
------------------------------
{'project_id': '184911'} |
|
/ok to test 95f3425 |
AnuradhaKaruppiah
approved these changes
Jun 27, 2025
Signed-off-by: Patrick Riel <priel@nvidia.com>
|
/ok to test 3cb095e |
|
LGTM, thanks for the contribution Patrick |
|
/merge |
mpenn
pushed a commit
to mpenn/NeMo-Agent-Toolkit
that referenced
this pull request
Jul 23, 2025
Closes NVIDIA#371 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Patrick (https://github.com/cheese-head) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#372 Signed-off-by: Matthew Penn <mpenn@nvidia.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
Closes NVIDIA#371 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Patrick (https://github.com/cheese-head) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#372
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
Closes NVIDIA#371 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Patrick (https://github.com/cheese-head) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #371
By Submitting this PR I confirm: