Remove AIQ prefix from class and function names
#606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Update mocks in tests Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv
added
improvement
…avid-aiq-prefix-rename Signed-off-by: David Gardner <dagardner@nvidia.com>
|
|
yczhang-nv
approved these changes
Aug 8, 2025
packages/nvidia_nat_redis/src/aiq/plugins/redis/redis_editor.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com> Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
|
/merge |
saglave
pushed a commit
to snps-scm13/SNPS-NeMo-Agent-Toolkit
that referenced
this pull request
Sep 2, 2025
## Description * Strip the `AIQ` prefix from class names such that `AIQContext` => `Context`, the idea here is that we don't need the name of the library in the class names as they are already in the package/namespace of the library. * Compatibility aliases were left in place to ease transition ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. --------- Signed-off-by: David Gardner <dagardner@nvidia.com> Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com> Co-authored-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com> Signed-off-by: Sangharsh Aglave <aglave@synopsys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AIQprefix from class names such thatAIQContext=>Context, the idea here is that we don't need the name of the library in the class names as they are already in the package/namespace of the library.By Submitting this PR I confirm: