KEMBAR78
Update `AIQ` to `NAT` in documentation and comments by yczhang-nv · Pull Request #614 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Aug 9, 2025

Description

  • Update all occurrences of AIQ/aiq to the new name NeMo Agent Toolkit or NAT in documentation and comments.
  • Remove unused get_distribution_name and get_distribution_name_from_private_data methods from the nat.data_models.discovery_metadata module. This is a breaking change.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
…ming-docs

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@yczhang-nv yczhang-nv self-assigned this Aug 9, 2025
@yczhang-nv yczhang-nv added doc Improvements or additions to documentation non-breaking Non-breaking change labels Aug 9, 2025
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
…ming-docs

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
…ming-docs

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@dagardner-nv dagardner-nv requested a review from Copilot August 12, 2025 23:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all occurrences of AIQ/aiq to the new name NeMo Agent Toolkit or NAT in documentation and comments across the codebase. This is a comprehensive rebranding effort that maintains consistency throughout the project.

Key changes include:

  • Updating variable names, function names, and class references from aiq to nat
  • Changing package references from aiqtoolkit to nvidia-nat
  • Updating configuration paths, URLs, and file names to use the new naming convention

Reviewed Changes

Copilot reviewed 271 out of 271 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/nat/tool/retriever.py Updates function alias from aiq_retriever_tool to nat_retriever_tool
src/nat/tool/mcp/exceptions.py Updates CLI command reference from 'aiq info mcp' to 'nat info mcp'
src/nat/tool/code_execution/test_code_execution_sandbox.py Updates sandbox directory path from src/aiq/ to src/nat/
src/nat/tool/code_execution/README.md Updates documentation paths from src/aiq/ to src/nat/
src/nat/tool/chat_completion.py Updates module description from "AIQ Toolkit" to "NAT"
src/nat/settings/global_settings.py Updates environment variable from AIQ_CONFIG_DIR to NAT_CONFIG_DIR
src/nat/front_ends/mcp/mcp_front_end_config.py Updates default MCP server name from "AIQ MCP" to "NeMo Agent Toolkit MCP"
src/nat/front_ends/fastapi/main.py Updates environment variables from AIQ_CONFIG_FILE/AIQ_FRONT_END_WORKER to NAT equivalents
src/nat/registry_handlers/package_utils.py Updates entry points from aiq.plugins to nat.plugins
src/nat/eval/evaluate.py Updates default workflow alias from aiqtoolkit-eval to nvidia-nat-eval
examples/observability/simple_calculator_observability/configs/*.yml Updates project names and component references to use nat instead of aiq
tests/**/*.py Updates variable names, comments, and test data from aiq/AIQ to nat/NAT throughout test files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed up to docs/source/reference/cursor-rules-reference.md

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small grammar fixes.

@willkill07
Copy link
Member

willkill07 commented Aug 13, 2025

FYI, I ran all e2e, integration, and long tests locally:

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃  File                                                          ┃  Function                                                                           ┃  Function Line  ┃  Error Line  ┃  Error                  ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━┩
│  tests/nat/compat/test_compatibility_aliases.py                │  test_compatibility_aliases[False-aiq.runtime.loader-get_all_aiq_entrypoints_dist…  │  40             │  94          │  AttributeError         │
│  tests/nat/compat/test_compatibility_aliases.py                │  test_compatibility_aliases[False-aiq.tool.retriever-aiq_retriever_tool-retriever…  │  40             │  94          │  AttributeError         │
│  tests/nat/compat/test_compatibility_aliases.py                │  test_compatibility_aliases[True-aiq.runtime.loader-get_all_aiq_entrypoints_distr…  │  40             │  94          │  AttributeError         │
│  tests/nat/compat/test_compatibility_aliases.py                │  test_compatibility_aliases[True-aiq.tool.retriever-aiq_retriever_tool-retriever_…  │  40             │  665         │  AssertionError         │
│  tests/nat/server/test_unified_api_server.py                   │  test_chat_stream_endpoint                                                          │  334            │  342         │  ValidationError        │
└────────────────────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────────────────┴─────────────────┴──────────────┴─────────────────────────┘

Of those, only the tests/nat/compat/test_compatibility_aliases.py tests run by default, so we will need to resolve them before merge.

For test_chat_stream_endpoint, the failure is Pydantic validation:

E       pydantic_core._pydantic_core.ValidationError: 2 validation errors for ChatResponseChunk
E       choices
E         Field required [type=missing, input_value={'id': '170c1871-601e-460...owledge_base=True\n```"}, input_type=dict]
E           For further information visit https://errors.pydantic.dev/2.10/v/missing
E       created
E         Field required [type=missing, input_value={'id': '170c1871-601e-460...owledge_base=True\n```"}, input_type=dict]
E           For further information visit https://errors.pydantic.dev/2.10/v/missing

I have fixed this locally with the following patch:

diff --git a/tests/nat/server/test_unified_api_server.py b/tests/nat/server/test_unified_api_server.py
index 2a9f8c0a..35f1609a 100644
--- a/tests/nat/server/test_unified_api_server.py
+++ b/tests/nat/server/test_unified_api_server.py
@@ -337,7 +337,9 @@ async def test_chat_stream_endpoint(client: httpx.AsyncClient, config: Config):
     input_message = {"messages": [{"role": "user", "content": f"{config.app.input}"}], "use_knowledge_base": True}
     response = await client.post(f"{config.endpoint.chat_stream}", json=input_message)
     assert response.status_code == 200
-    data_match: re.Match[str] | None = re.search(r'data:\s*(.*)', response.text)
+    # only match the explicit `data:` json response
+    data_match: re.Match[str] | None = re.search(r'\bdata:\s*(.[^\n]*)\n', response.text)
+    assert data_match is not None
     data_match_dict: dict = json.loads(data_match.group(1))
     validated_response = ChatResponseChunk(**data_match_dict)
     assert isinstance(validated_response, ChatResponseChunk)

Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes pytest failures

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed up to examples/evaluation_and_profiling/simple_calculator_eval/README.md

Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
dagardner-nv and others added 15 commits August 13, 2025 14:03
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ntIQ into david-yuchen-update-naming-docs-p3

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ntIQ into david-yuchen-update-naming-docs-p3

Signed-off-by: David Gardner <dagardner@nvidia.com>
…cs-p3

Ignore the 'custom-server' url in list_mcp.py module
Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
…xecute_function.py

Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@dagardner-nv dagardner-nv self-requested a review August 13, 2025 22:05
dagardner-nv and others added 2 commits August 13, 2025 15:12
Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv and others added 3 commits August 13, 2025 15:37
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ming-docs

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
@dagardner-nv dagardner-nv merged commit 2264108 into NVIDIA:develop Aug 13, 2025
8 of 9 checks passed
@yczhang-nv yczhang-nv deleted the yuchen-update-naming-docs branch August 15, 2025 21:15
saglave pushed a commit to snps-scm13/SNPS-NeMo-Agent-Toolkit that referenced this pull request Sep 2, 2025
## Description
<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". All PRs
should have an issue they close-->

- Update all occurrences of `AIQ/aiq` to the new name `NeMo Agent
Toolkit` or `NAT` in documentation and comments.
- Remove unused `get_distribution_name` and
`get_distribution_name_from_private_data` methods from the
`nat.data_models.discovery_metadata` module. **This is a breaking
change.**

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This
certifies that the contribution is your original work, or you have
rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will
not be accepted.
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.

---------

Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Co-authored-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: Sangharsh Aglave <aglave@synopsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change doc Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants