KEMBAR78
Rename `aiq` namespace to `nat` by dagardner-nv · Pull Request #618 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 11, 2025

Description

  • Rename the Python API aiq namespace to nat
  • Rename the aiq CLI tool to nat
  • Leaving a compatibility alias in place for both.
  • Rename the VSCode project name
  • Rename the aiq_ prefix in examples code paths
  • Pylint is currently failing due to this PR touching all Python files, other checks (isort, flake8, yapf, uv-lock and link check) are passing, as are the unittests.
  • Rename submodule external/aiqtoolkit-opensource-ui -> external/nat-ui
  • Rename default output_dir in example YAMLs from .tmp/aiq/... to .tmp/nat/...

Things not in this PR to be handled in another PR:

  • Documentation updates
  • Docstring updates

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Update mocks in tests

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…avid-aiq-prefix-rename

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…avid-rename-rename-rename

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv and others added 5 commits August 11, 2025 16:49
…porter.py

Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…AIQtoolkit into david-rename-rename-rename

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…avid-rename-rename-rename

Signed-off-by: David Gardner <dagardner@nvidia.com>
dagardner-nv and others added 7 commits August 12, 2025 07:51
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
…yst_exporter.py

Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…AIQtoolkit into david-rename-rename-rename

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv requested a review from Copilot August 12, 2025 16:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The pull request renames the Python API aiq namespace to nat and the aiq CLI tool to nat across the entire codebase while maintaining compatibility aliases. This includes updating imports, package names, entry points, and file paths throughout the project.

  • Rename Python API namespace from aiq to nat
  • Rename CLI tool from aiq to nat
  • Update all imports, package names, and example project structures

Reviewed Changes

Copilot reviewed 200 out of 954 changed files in this pull request and generated 1 comment.

File Description
nat.code-workspace Updates VS Code project configuration to disable Python language server
packages/nvidia_nat_agno/ Renames Agno integration package imports and entry points
examples/ Comprehensive update of all example packages to use nat namespace
docs/source/ Updates documentation references from aiq to nat

dagardner-nv and others added 2 commits August 12, 2025 09:45
Signed-off-by: David Gardner <dagardner@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
… the pypi package name

Signed-off-by: David Gardner <dagardner@nvidia.com>
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback

dagardner-nv and others added 6 commits August 12, 2025 12:43
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
@dagardner-nv dagardner-nv merged commit c0055ac into NVIDIA:develop Aug 12, 2025
8 of 9 checks passed
@dagardner-nv dagardner-nv deleted the david-rename-rename-rename branch August 12, 2025 20:01
saglave pushed a commit to snps-scm13/SNPS-NeMo-Agent-Toolkit that referenced this pull request Sep 2, 2025
* Rename the Python API `aiq` namespace to `nat`
* Rename the `aiq` CLI tool to `nat`
* Leaving a compatibility alias in place for both.
* Rename the VSCode project name
* Rename the `aiq_` prefix in examples code paths
* Pylint is currently failing due to this PR touching all Python files,
other checks (isort, flake8, yapf, uv-lock and link check) are passing,
as are the unittests.
* Rename submodule `external/aiqtoolkit-opensource-ui` ->
`external/nat-ui`
* Rename default `output_dir` in example YAMLs from `.tmp/aiq/...` to
`.tmp/nat/...`

Things not in this PR to be handled in another PR:
* Documentation updates
* Docstring updates

- I am familiar with the [Contributing
Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md).
- We require that all contributors "sign-off" on their commits. This
certifies that the contribution is your original work, or you have
rights to submit it under the same license, or a compatible license.
- Any contribution which contains commits that are not Signed-Off will
not be accepted.
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.

---------

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Co-authored-by: Will Killian <2007799+willkill07@users.noreply.github.com>
Co-authored-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change improvement Improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants