Add missing platformdirs dependency
#62
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
AnuradhaKaruppiah
approved these changes
Apr 2, 2025
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 2, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62 Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 14, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62
yczhang-nv
added a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
Apr 21, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62 Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv
added a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62 Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes NVIDIA#39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #39,
platformdirsshould be included as a dependency ofAgentIQcore component.This issue does not occur when installing from source since
uv.lockalready includesplatformdirs. However, thepypipackage does not includeuv.lock(and causes the missing dependency issue).Closes #39 (the
pypipackage needs to be updated)By Submitting this PR I confirm: