Normalize Gannt Chart Timestamps in Profiler Nested Stack Analysis #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. Signed-off-by: dnandakumar-nv <168006707+dnandakumar-nv@users.noreply.github.com>
dnandakumar-nv
added
improvement
AnuradhaKaruppiah
approved these changes
Apr 2, 2025
|
/ok to test |
yczhang-nv
approved these changes
Apr 2, 2025
|
/ok to test |
dagardner-nv
approved these changes
Apr 2, 2025
src/aiq/profiler/inference_optimization/bottleneck_analysis/nested_stack_analysis.py
Outdated
Show resolved
Hide resolved
Replaced a redundant `min()` computation with direct access to the first element of the sorted list. This improves readability and ensures better performance by avoiding an unnecessary iteration. Signed-off-by: dnandakumar-nv <168006707+dnandakumar-nv@users.noreply.github.com>
|
/ok to test |
|
/merge |
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Apr 14, 2025
…VIDIA#70) Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#70
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
Apr 21, 2025
…VIDIA#70) Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#70 Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
…VIDIA#70) Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#70 Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
…VIDIA#70) Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#70
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
…VIDIA#70) Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps.
Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations.
By Submitting this PR I confirm: