KEMBAR78
Allow overriding configuration values not set in the YAML by dagardner-nv · Pull Request #85 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 4, 2025

Description

  • This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the --override flag.
  • Remove unnecessary assert in src/aiq/data_models/common.py as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
  • Add unittests for the LayeredConfig class.

Closes #83

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
…y using the module name. This makes it easier for me to test things out with ipython

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 4, 2025
@dagardner-nv dagardner-nv self-assigned this Apr 4, 2025
@dagardner-nv dagardner-nv requested a review from a team as a code owner April 4, 2025 17:47
…verrides-83

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2ea93d4 into NVIDIA:develop Apr 4, 2025
10 checks passed
@dagardner-nv dagardner-nv deleted the david-yaml-overrides-83 branch April 4, 2025 18:20
ericevans-nv pushed a commit to ericevans-nv/agent-iq that referenced this pull request Apr 14, 2025
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag.
* Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
* Add unittests for the `LayeredConfig` class.

Closes NVIDIA#83

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#85
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request Apr 21, 2025
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag.
* Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
* Add unittests for the `LayeredConfig` class.

Closes NVIDIA#83

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#85
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag.
* Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
* Add unittests for the `LayeredConfig` class.

Closes NVIDIA#83

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#85
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag.
* Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
* Add unittests for the `LayeredConfig` class.

Closes NVIDIA#83

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#85
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag.
* Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter.
* Add unittests for the `LayeredConfig` class.

Closes NVIDIA#83

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: aiq run should allow overriding parameters on the command line not set in the YAML

2 participants