KEMBAR78
[NvBug 5370718, 5371538] fix: Fix incremental detokenization by syuoni · Pull Request #5825 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@syuoni
Copy link
Collaborator

@syuoni syuoni commented Jul 8, 2025

[NvBug 5370718, 5371538] fix: Fix incremental detokenization

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@syuoni syuoni requested a review from kaiyux July 8, 2025 06:36
@syuoni
Copy link
Collaborator Author

syuoni commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11229 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11229 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8306 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented Jul 8, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11276 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11276 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #8340 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented Jul 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11371 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11371 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8411 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

syuoni added 4 commits July 9, 2025 11:50
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
@syuoni syuoni force-pushed the fix-incremental-detokenize branch from 69ff1c3 to b213b5b Compare July 9, 2025 11:52
syuoni added 2 commits July 9, 2025 13:19
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
@syuoni
Copy link
Collaborator Author

syuoni commented Jul 9, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11443 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11443 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #8464 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented Jul 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11479 [ run ] triggered by Bot

Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the help to fix.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11479 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8494 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented Jul 10, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11503 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11503 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8511 completed with status: 'SUCCESS'

@syuoni syuoni merged commit 055c4a9 into NVIDIA:main Jul 10, 2025
3 checks passed
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
…5825)

Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Yuxin <yuxinz@nvidia.com>
@syuoni syuoni deleted the fix-incremental-detokenize branch July 31, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants