KEMBAR78
fix: [5376140] [AutoDeploy] Update unit tests: skip all_close assert for dropout in attention, increase tolerance for rope op test by Fridah-nv · Pull Request #5855 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@Fridah-nv
Copy link
Collaborator

@Fridah-nv Fridah-nv commented Jul 8, 2025

Description

Fix B200 tests failure for torch version 2.8.0a0+5228986c39.nv25.6
Related to #5678

Test Coverage

Tested tests/unittest/_torch/auto_deploy/unit on B200 and A6000 with container
urm.nvidia.com/sw-tensorrt-docker/tensorrt-llm:pytorch-25.06-py3-x86_64-ubuntu24.04-trt10.11.0.33-skip-tritondevel-202507031358-5678

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…_op_variants with loser tolerance

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
@Fridah-nv
Copy link
Collaborator Author

/bot run

@Fridah-nv Fridah-nv requested review from lucaslie and suyoggupta July 8, 2025 18:33
@Fridah-nv Fridah-nv self-assigned this Jul 8, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11338 [ run ] triggered by Bot

@github-project-automation github-project-automation bot moved this from Backlog to In review in AutoDeploy Board Jul 8, 2025
@lucaslie lucaslie enabled auto-merge (squash) July 8, 2025 21:40
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11338 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8389 completed with status: 'FAILURE'

@Fridah-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11349 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11349 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8400 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit a79b73f into NVIDIA:main Jul 9, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Jul 9, 2025
@Fridah-nv Fridah-nv deleted the user/fridah/fix-tests-2506 branch July 9, 2025 00:24
lucaslie pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Jul 10, 2025
…for dropout in attention, increase tolerance for rope op test (NVIDIA#5855)

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 11, 2025
…for dropout in attention, increase tolerance for rope op test (NVIDIA#5855)

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
…for dropout in attention, increase tolerance for rope op test (NVIDIA#5855)

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Yuxin <yuxinz@nvidia.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 17, 2025
…for dropout in attention, increase tolerance for rope op test (NVIDIA#5855)

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 21, 2025
…for dropout in attention, increase tolerance for rope op test (NVIDIA#5855)

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants