[TRTLLM-6791][infra] Add check for uploading stage name and avoid overriding test result tar file #6742
Conversation
📝 WalkthroughWalkthroughAdds a global Changes
Sequence Diagram(s)sequenceDiagram
participant Pipeline
participant cacheErrorAndUploadResult
participant GlobalState
Pipeline->>cacheErrorAndUploadResult: call(stageName, taskRunner, finallyRunner)
cacheErrorAndUploadResult->>GlobalState: check contains(stageName)?
alt not present
GlobalState->>GlobalState: add(stageName)
cacheErrorAndUploadResult->>Pipeline: perform upload and finish
else present
cacheErrorAndUploadResult->>Pipeline: wrap error -> mark stage/build FAILURE (duplicate upload)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --skip-test --disable-fail-fast |
ZhanruiSunCh
changed the title
|
PR_Github #14585 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
|
PR_Github #14585 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
38429d9 to
5d92433
Compare
|
/bot run --skip-test --disable-fail-fast |
|
PR_Github #14886 [ run ] triggered by Bot |
|
PR_Github #14886 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
dd039c8 to
3f26328
Compare
|
/bot run --skip-test --disable-fail-fast |
|
PR_Github #15108 [ run ] triggered by Bot |
|
PR_Github #15108 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #15871 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #15871 [ reuse-pipeline ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
3f26328 to
b357c66
Compare
|
/bot run --skip-test |
|
PR_Github #17194 [ run ] triggered by Bot |
|
PR_Github #17194 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
b357c66 to
be49cd3
Compare
|
/bot run --skip-test |
|
PR_Github #17354 [ run ] triggered by Bot |
|
PR_Github #17354 [ run ] completed with state |
chzblych
changed the title
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
b7fa43b to
96d045c
Compare
|
/bot run --skip-test --disable-fail-fast |
|
PR_Github #18444 [ run ] triggered by Bot |
|
PR_Github #18444 [ run ] completed with state |
…ide of test result tar Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>
…k stage Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
ZhanruiSunCh
force-pushed
the
user/zhanruis/0808_fix_jira_6791
branch
from
96d045c to
ca6d96a
Compare
|
/bot run --skip-test --disable-fail-fast --extra-stage "GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-3" |
|
PR_Github #18469 [ run ] triggered by Bot |
|
/bot skip --comment "Only GB200 failed due to known issue on main branch" |
|
PR_Github #18469 [ run ] completed with state |
|
PR_Github #18481 [ skip ] triggered by Bot |
|
PR_Github #18481 [ skip ] completed with state |
…rriding test result tar file (NVIDIA#6742) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
…rriding test result tar file (NVIDIA#6742) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
3 participants
Summary by CodeRabbit
Bug Fixes
New Features
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.