[None][infra] Adjust labeling llm prompt for bug issues #7385
Conversation
📝 WalkthroughWalkthroughUpdated the GitHub Actions issue-labeling workflow’s LLM system prompt to allow bugs to include additional secondary labels from a predefined set, outputting multiple labels as comma-separated values while retaining NONE as a valid outcome. No logic or API changes beyond prompt text. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as GitHub User
participant GH as GitHub Issues
participant WF as GH Workflow: label_issue.yml
participant LLM as Labeling LLM
U->>GH: Open/Update Issue
GH-->>WF: Trigger workflow
WF->>LLM: Send issue content + system prompt
Note over LLM: For bug issues, include primary label<br/>and optional secondary labels<br/>(comma-separated)
LLM-->>WF: Return label list (or NONE)
WF->>GH: Apply returned labels to issue
Note over GH,WF: No other control flow changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/label_issue.yml (1)
41-48: Resolve conflict: 'bug' is excluded but prompt asks to label bugs.EXCLUDED_LABELS includes "bug", yet the prompt instructs labeling bugs and adding secondaries. Clarify that the model must not output "bug" and only emit secondary labels when the issue is a bug, otherwise it may return "bug" and be ignored or cause inconsistent behavior.
Apply this diff to tighten the instruction:
-When labeling bugs, include secondary labels from Customized kernels, Decoding, Disaggregated serving, Doc, Frontend, General perf, Inference runtime, Infra, LLM API, Model customization, Model optimization, OOTB, Pytorch, Scale-out, Speculative Decoding, Testing, Triton backend, and Windows. +If the issue is a bug (the 'bug' label may be applied separately and is excluded here), output ONLY the applicable secondary labels from this exact allowlist: Customized kernels, Decoding, Disaggregated serving, Doc, Frontend, General perf, Inference runtime, Infra, LLM API, Model customization, Model optimization, OOTB, Pytorch, Scale-out, Speculative Decoding, Testing, Triton backend, Windows. Use exact casing; if none apply, respond with 'NONE'. Do not output 'bug'.
🧹 Nitpick comments (2)
.github/workflows/label_issue.yml (2)
41-48: Tighten CSV output expectations to reduce parsing errors.Explicitly require exact comma-separated values with single spaces after commas and no trailing comma. This reduces churn from models emitting varied spacing.
Suggested tweak (append to the existing output rule at Line 45 or integrate into Line 47 rewrite): “Return labels as 'Label A, Label B' (comma and single space), with no trailing comma.”
41-48: Avoid contradicting the “single label preferred” rule for non-bugs.Call out that multiple labels should be used only for bugs (primary handled elsewhere) or truly cross-cutting issues; otherwise emit one.
No code change required if Line 47 is rewritten as suggested; this is a reminder to keep the prompt unambiguous.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/label_issue.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
.github/workflows/label_issue.yml (1)
41-48: All listed secondary labels exist with correct casing; no changes needed.
karljang
changed the title
karljang
changed the title
|
/bot skip --comment "GitHub action only" |
|
PR_Github #17027 [ skip ] triggered by Bot |
|
PR_Github #17027 [ skip ] completed with state |
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
Also adjusted module assignees Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
karljang
force-pushed
the
adjust-bug-label
branch
from
9b09059 to
3d92605
Compare
|
/bot skip --comment "GitHub action only" |
|
PR_Github #18407 [ skip ] triggered by Bot |
|
PR_Github #18407 [ skip ] completed with state |
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
[v] Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.