KEMBAR78
[None][chore] Remove closed bugs by xinhe-nv · Pull Request #7408 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 31, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Re-enabled several previously skipped integration and accuracy tests, improving test coverage and confidence in stability.
    • Removed outdated waivers so affected scenarios now run in CI.
    • No user-facing behavior changes.

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250831 branch from 8efc0db to 953364b Compare September 4, 2025 07:29
@xinhe-nv xinhe-nv marked this pull request as ready for review September 4, 2025 07:29
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 4, 2025 07:29
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Sep 4, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2025

📝 Walkthrough

Walkthrough

Removed specific SKIP waivers from tests/integration/test_lists/waives.txt, re-enabling corresponding integration and accuracy tests.

Changes

Cohort / File(s) Summary of Changes
Test waiver removals
tests/integration/test_lists/waives.txt
Deleted SKIP lines for: tests/integration/test_e2e.py::test_openai_multi_chat_example, accuracy/test_llm_api_pytorch.py::TestLlama3_3_70BInstruct::test_fp8_tp4, accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype[mtp_nextn=0-overlap_scheduler=True], examples/test_llama.py::test_llm_api_lookahead_decoding_1gpu[...]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7090b28 and 953364b.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17647 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17647 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13266 completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250831 branch from 953364b to 67e3b4d Compare September 5, 2025 01:44
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Sep 5, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17727 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17727 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #17647 for commit 67e3b4d

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250831 branch from 67e3b4d to ec774d6 Compare September 5, 2025 04:16
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Sep 5, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17750 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17750 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #17647 for commit ec774d6

@xinhe-nv xinhe-nv merged commit b3ba3d9 into NVIDIA:main Sep 5, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20250831 branch September 5, 2025 07:13
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants