[TRTLLM-6199][infra] Update for using open driver from BSL #7430
Conversation
|
/bot run --stage-list "B200_PCIe-Triton-Post-Merge-1, RTXPro6000-4_GPUs-Pytorch-Post-Merge-1, DGX_H100-4_GPUs-CPP-1" |
📝 WalkthroughWalkthroughCentralizes GPU driver handling in jenkins/L0_Test.groovy by adding two global type lists and updating createKubernetesPodConfig to derive driver version from REQUIRED_OPEN_DRIVER_TYPES and no-driver gating from REQUIRED_NO_DRIVER_TYPES. Previous hardcoded checks are replaced; overall function structure remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant L0_Test.groovy as L0_Test.groovy
participant PodConfig as createKubernetesPodConfig
Caller->>PodConfig: createKubernetesPodConfig(type)
activate PodConfig
Note over PodConfig: Evaluate GPU type
alt Type requires no driver
PodConfig->>PodConfig: if type in REQUIRED_NO_DRIVER_TYPES
Note over PodConfig: Skip driver mounts
else Driver required
PodConfig->>PodConfig: Select driverVersion
Note over PodConfig: driverVersion = DEFAULT_NVIDIA_OPEN_DRIVER_VERSION if type in REQUIRED_OPEN_DRIVER_TYPES else DEFAULT_NVIDIA_DRIVER_VERSION
PodConfig->>PodConfig: Configure driver mounts
end
PodConfig-->>Caller: Pod spec config
deactivate PodConfig
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
98-103: Promote these lists to @field constants for CPS-stability and consistencyMatch the style of other globals to avoid accidental rebinding across CPS resumes and to keep semantics clear.
Consider moving these GPU-type sets into the shared lib (e.g., Constants) so multiple pipelines don’t drift.
-// GPU types that require open driver -REQUIRED_OPEN_DRIVER_TYPES = ["b100-ts2", "rtx-5080", "rtx-5090", "rtx-pro-6000"] +// GPU types that require open driver +@Field +def REQUIRED_OPEN_DRIVER_TYPES = ["b100-ts2", "rtx-5080", "rtx-5090", "rtx-pro-6000"] -// GPU types that don't support dynamic driver flashing -REQUIRED_NO_DRIVER_TYPES = ["dgx-h100", "dgx-h200", "gh200"] +// GPU types that don't support dynamic driver flashing +@Field +def REQUIRED_NO_DRIVER_TYPES = ["dgx-h100", "dgx-h200", "gh200"]
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_Test.groovy (2)
819-833: Confirm intent: rtx-pro-6000 moved from “no-driver” to “open driver” pathPreviously rtx-pro-6000 appeared in the no-dynamic-driver list; now it’s treated as open-driver-capable (and not in REQUIRED_NO_DRIVER_TYPES). Ensure those testers support dynamic driver selection via node label, or scheduling will stall.
If this is intentional, consider adding an inline comment noting the change in policy to avoid regressions.
802-804: Guard DEFAULT_NVIDIA_OPEN_DRIVER_VERSION with fallback
Wrap access toConstants.DEFAULT_NVIDIA_OPEN_DRIVER_VERSIONin a try/catch (or usehasProperty) falling back toConstants.DEFAULT_NVIDIA_DRIVER_VERSIONto prevent load-time failures; verify the shared library publishes the open-driver constant.
|
PR_Github #17181 [ run ] triggered by Bot |
|
PR_Github #17181 [ run ] completed with state |
EmmaQiaoCh
force-pushed
the
emma/use_open_driver_in_bsl
branch
from
569bc05 to
0b477f7
Compare
|
/bot run --stage-list "B200_PCIe-Triton-Post-Merge-1, RTXPro6000-4_GPUs-Pytorch-Post-Merge-1, DGX_H100-4_GPUs-CPP-1" |
|
PR_Github #17279 [ run ] triggered by Bot |
|
PR_Github #17279 [ run ] completed with state |
Signed-off-by: qqiao <qqiao@nvidia.com>
EmmaQiaoCh
force-pushed
the
emma/use_open_driver_in_bsl
branch
from
0b477f7 to
fd9f7f2
Compare
|
/bot run |
|
PR_Github #17332 [ run ] triggered by Bot |
|
PR_Github #17332 [ run ] completed with state |
|
/bot run |
|
PR_Github #17506 [ run ] triggered by Bot |
|
PR_Github #17506 [ run ] completed with state |
Signed-off-by: qqiao <qqiao@nvidia.com>
3 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.