[None][chore] Remove two unused parameters in create_py_executor #7458
Conversation
|
/bot run |
📝 WalkthroughWalkthroughThe PyTorch executor creation API removed two parameters (logits_post_processor_config, parallel_config), and worker code stopped computing/passing them to the PyTorch path. Engine path remains unchanged. No other control flow or error handling changes were introduced. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Worker as Worker._create_py_executor
participant Creator as PyExecutorCreator.create_py_executor
Note over Worker,Creator: BEFORE (PyTorch path)
Client->>Worker: request PyExecutor
Worker->>Worker: build logits_post_processor_config<br/>build parallel_config (comm_ranks, device_ids)
Worker->>Creator: create_py_executor(..., logits_post_processor_config, parallel_config)
Creator-->>Worker: PyExecutor
Worker-->>Client: PyExecutor
rect rgb(250,250,210)
Note over Worker,Creator: AFTER (PyTorch path) — removed params
Client->>Worker: request PyExecutor
Worker->>Creator: create_py_executor(...)
Creator-->>Worker: PyExecutor
Worker-->>Client: PyExecutor
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
|
PR_Github #17269 [ run ] triggered by Bot |
|
PR_Github #17270 [ run ] triggered by Bot |
|
PR_Github #17269 [ run ] completed with state |
|
PR_Github #17270 [ run ] completed with state |
|
/bot run |
|
PR_Github #17303 [ run ] triggered by Bot |
leslie-fang25
force-pushed
the
leslie/remove_two_parameters_in_create_py_executor
branch
from
a8521a3 to
32cb853
Compare
|
/bot run |
|
PR_Github #17305 [ run ] triggered by Bot |
|
PR_Github #17303 [ run ] completed with state |
|
PR_Github #17305 [ run ] completed with state |
|
/bot run |
|
PR_Github #17331 [ run ] triggered by Bot |
|
PR_Github #17331 [ run ] completed with state |
Signed-off-by: leslie-fang25 <leslief@nvidia.com>
Signed-off-by: leslie-fang25 <leslief@nvidia.com>
leslie-fang25
force-pushed
the
leslie/remove_two_parameters_in_create_py_executor
branch
from
32cb853 to
1e05b8f
Compare
|
/bot run |
|
PR_Github #17355 [ run ] triggered by Bot |
|
PR_Github #17355 [ run ] completed with state |
Signed-off-by: leslie-fang25 <leslief@nvidia.com>
|
/bot run |
|
PR_Github #17437 [ run ] triggered by Bot |
|
PR_Github #17437 [ run ] completed with state |
|
/bot run |
|
PR_Github #17487 [ run ] triggered by Bot |
|
PR_Github #17487 [ run ] completed with state |
…DIA#7458) Signed-off-by: leslie-fang25 <leslief@nvidia.com>
4 participants
Summary by CodeRabbit
Description
There are two parameters
logits_post_processor_configandparallel_configwhich should be not used inside thecreate_py_executor. Remove them in this PR.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.