KEMBAR78
[None][fix] Update DG side branch name by Barry-Delaney · Pull Request #7491 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

[None][fix] Update DG side branch name #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

[None][fix] Update DG side branch name #7491

merged 1 commit into from
Sep 4, 2025

Conversation

@Barry-Delaney
Copy link
Collaborator

@Barry-Delaney Barry-Delaney commented Sep 3, 2025 •
edited by coderabbitai bot
Loading

This PR updates the side branch name of DeepGEMM for unblocking the post-merge pipeline.

Summary by CodeRabbit

  • Chores
    • Updated third-party submodule to track a different branch for future updates, aligning with current upstream configuration. No functional or UI changes; builds and behavior remain the same for end users. This is a maintenance update to dependency management and does not require any action. Existing installations continue to work without updates or migrations.

@Barry-Delaney
Update DG side branch name
cbb1884 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
@Barry-Delaney Barry-Delaney self-assigned this Sep 3, 2025
@Barry-Delaney
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

📝 Walkthrough

Walkthrough

Updated .gitmodules to change the tracked branch for submodule 3rdparty/DeepGEMM from dev/ruoqiang/swapab_sm100 to swapab_sm100. Path and URL are unchanged.

Changes

Cohort / File(s) Summary of Changes
Submodule config
/.gitmodules		 Switched submodule branch for 3rdparty/DeepGEMM from dev/ruoqiang/swapab_sm100 to swapab_sm100; kept path and URL unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
.gitmodules (1)

32-32: Confirm CI/submodule update mode or this change has no effect.

If your pipelines use the default “git submodule update --init --recursive” (no --remote), the branch field is ignored and the recorded commit is used. If you intend to track swapab_sm100 automatically, ensure CI uses “git submodule update --remote --init --recursive” (ideally with shallow depth) and that this is acceptable for the release/1.1.0rc2 line.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 935c2c1 and cbb1884.

📒 Files selected for processing (1)
  • .gitmodules (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17449 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17449 [ run ] completed with state FAILURE
/LLM/release-1.1.0rc2/L0_MergeRequest_PR pipeline #33 completed with status: 'FAILURE'

@Barry-Delaney
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17463 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17463 [ run ] completed with state FAILURE
/LLM/release-1.1.0rc2/L0_MergeRequest_PR pipeline #37 completed with status: 'FAILURE'

@Barry-Delaney
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17518 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #17518 [ run ] completed with state SUCCESS
/LLM/release-1.1.0rc2/L0_MergeRequest_PR pipeline #45 completed with status: 'SUCCESS'

@litaotju litaotju merged commit d32e462 into NVIDIA:release/1.1.0rc2 Sep 4, 2025
8 of 9 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 4, 2025
Merged
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 15, 2025
@Barry-Delaney
[None][fix] Update DG side branch name (NVIDIA#7491)
ad9c3f0 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG side branch name (NVIDIA#7491)
0174b78 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG side branch name (NVIDIA#7491)
1138421 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 17, 2025
@Barry-Delaney
[None][fix] Update DG side branch name (NVIDIA#7491)
39b7a47 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Barry-Delaney added a commit to Barry-Delaney/TensorRT-LLM that referenced this pull request Sep 18, 2025
@Barry-Delaney
[None][fix] Update DG side branch name (NVIDIA#7491)
bd7dbba 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@litaotju litaotju litaotju approved these changes

@zongfeijing zongfeijing Awaiting requested review from zongfeijing

Assignees

@Barry-Delaney Barry-Delaney

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Delaney @tensorrt-cicd @litaotju