[None][infra] update nspect version #7552

niukuo · 2025-09-05T02:59:29Z

Summary by CodeRabbit

Chores
- Updated security scanning pipeline to use the latest repository revision for image checks, ensuring up-to-date vulnerability assessments.
- No changes to build logic, control flow, or error handling.
Impact
- No user-facing changes; product functionality and deployments remain unaffected.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

niukuo · 2025-09-05T03:00:49Z

/bot run --stage-list "Build-Docker-Images"

coderabbitai · 2025-09-05T03:01:18Z

📝 Walkthrough

Walkthrough

Updated the NSPECT repository commit SHA used in the "Register NGC Images for Security Checks" stage within Jenkins BuildDockerImage.groovy. No other logic or control flow was modified.

Changes

Cohort / File(s)	Summary
CI Pipeline `jenkins/BuildDockerImage.groovy`	Updated NSPECT repo checkout commit from `58ee430c8c3bd36bee2073405a547d3f8bc1932f` to `0e46042381ae25cb7af2f1d45853dfd8e1d54e2d` in the "Register NGC Images for Security Checks" stage; no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

jenkins/BuildDockerImage.groovy (1)
666-672: LGTM on bump; consider making the ref overridable and add a quick guard.

Make the nspect ref a pipeline parameter so you don’t need PRs for future bumps.

Fail fast if the CLI path changes at that ref.

Apply inline changes:
-                        def nspect_commit = "0e46042381ae25cb7af2f1d45853dfd8e1d54e2d"
+                        def nspect_commit = params.nspect_ref ?: "0e46042381ae25cb7af2f1d45853dfd8e1d54e2d"
+                        echo "NSPECT ref: ${nspect_commit}"
                         withCredentials([string(credentialsId: "TRTLLM_NSPECT_REPO", variable: "NSPECT_REPO")]) {
                             trtllm_utils.checkoutSource("${NSPECT_REPO}", nspect_commit, "nspect")
                         }
+                        sh "test -f nspect/nspect.py || { echo 'nspect.py not found at ref ${nspect_commit}'; exit 1; }"
Add a parameter (outside this hunk, in the parameters block):
string(
    name: "nspect_ref",
    defaultValue: "0e46042381ae25cb7af2f1d45853dfd8e1d54e2d",
    description: "NSPECT git ref (commit SHA or tag)"
)
Optional: if nspect ships a requirements.txt, install it after checkout to avoid runtime surprises:
if (fileExists("nspect/requirements.txt")) {
    trtllm_utils.llmExecStepWithRetry(this, script: "python3 -m pip install -r nspect/requirements.txt")
}
Please verify the new ref still supports flags used here (--register, --osrb_ticket, --check_launch_api, --wait_success) by running python3 nspect/nspect.py --help once after checkout.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2189a2f and 0f03ae5.

📒 Files selected for processing (1)

jenkins/BuildDockerImage.groovy (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

tensorrt-cicd · 2025-09-05T03:05:52Z

PR_Github #17738 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-05T03:05:53Z

PR_Github #17738 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User niukuo is not in the prioritized list. L0 testing cannot be triggered.

tensorrt-cicd · 2025-09-05T03:44:55Z

PR_Github #17742 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-05T07:33:33Z

PR_Github #17742 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #13300 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com> Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

niukuo requested review from a team as code owners September 5, 2025 02:59

niukuo requested review from omera-nv and tburt-nv September 5, 2025 02:59

update nspect version

0f03ae5

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

niukuo force-pushed the nspect branch from d5ecf4e to 0f03ae5 Compare September 5, 2025 02:59

coderabbitai bot reviewed Sep 5, 2025

View reviewed changes

chzblych approved these changes Sep 5, 2025

View reviewed changes

chzblych merged commit 163b1fc into NVIDIA:main Sep 5, 2025
6 of 9 checks passed

chzblych pushed a commit that referenced this pull request Sep 6, 2025

[None][infra] update nspect version (#7552)

fcdc55b

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

chzblych pushed a commit that referenced this pull request Sep 6, 2025

[None][infra] update nspect version (#7552)

88d1bde

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 9, 2025

[None][infra] update nspect version (NVIDIA#7552)

b03d058

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025

[None][infra] update nspect version (NVIDIA#7552)

21bb480

Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][infra] update nspect version #7552

[None][infra] update nspect version #7552

Uh oh!

niukuo commented Sep 5, 2025 •

edited

Loading

Uh oh!

niukuo commented Sep 5, 2025

Uh oh!

coderabbitai bot commented Sep 5, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[None][infra] update nspect version #7552

[None][infra] update nspect version #7552

Uh oh!

Conversation

niukuo commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

niukuo commented Sep 5, 2025

Uh oh!

coderabbitai bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

niukuo commented Sep 5, 2025 •

edited

Loading

coderabbitai bot commented Sep 5, 2025 •

edited

Loading