-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[#7288][feat] Added AutoDeploy backend support to test_perf.py #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/bot run |
|
PR_Github #17921 [ run ] triggered by Bot |
📝 WalkthroughWalkthroughAdds first-class Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant TR as Test Runner
participant PC as PerfTestConfig
participant BC as Bench Cmd Builder
participant AD as Autodeploy Runtime
participant MC as Metrics Collector
TR->>PC: load_from_str(params incl. backend)
PC-->>TR: PerfTestConfig (incl. autodeploy opts)
TR->>BC: get_commands(config)
alt backend == _autodeploy
BC->>BC: skip build phase
BC->>BC: write extra_llm_api_options.yaml (compile_backend, free_mem_ratio, runtime, skip_loading_weights)
BC-->>TR: bench cmd with --backend=_autodeploy and --extra_llm_api_options
else backend == pytorch
BC->>BC: skip build phase
BC-->>TR: bench cmd with --backend=pytorch
else tensorrt engine
BC->>BC: include --engine_dir
BC-->>TR: bench cmd with --backend=tensorrt
end
TR->>AD: execute bench command
AD-->>TR: runtime logs
TR->>MC: parse logs
alt backend in {pytorch, _autodeploy}
MC->>MC: omit BUILD_TIME metric
else
MC->>MC: include BUILD_TIME metric
end
MC-->>TR: metrics
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
tests/integration/defs/perf/test_perf.py (3)
389-394: Consistently namespace new AD params to avoid confusion.Consider prefixing all AutoDeploy-specific kwargs with
ad_(e.g.,ad_free_mem_ratio,ad_runtime,ad_skip_loading_weights) to avoid confusion with existing fields likeruntimeandkv_cache_free_gpu_mem_fraction. Keeps config surface clear and prevents accidental reuse in other backends.
447-451: Add light validation for new AD fields.At minimum: assert
0 < free_mem_ratio <= 1whenbackend == "_autodeploy". Optional: guard against emptyad_compile_backendandextra_runtime. This prevents silent misconfigurations at collection time.
475-479: Include backend in bench label — OK; optionally add AD knobs when non-default.Current label adds
_autodeploy. Optionally append compact flags (only when diverging from defaults), e.g.,ad_cb:torch-opt,ad_rt:trtllm, to disambiguate logs and cache keys. Not strictly required if config files are uniquely named (see next comment).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/defs/perf/test_perf.py(8 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/integration/defs/perf/test_perf.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/integration/defs/perf/test_perf.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/integration/defs/perf/test_perf.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (4)
tests/integration/defs/perf/test_perf.py (4)
592-593: Backend parsing updated to recognize “_autodeploy” — looks correct.No issues spotted in
load_from_str; unknown backends still fall back to TensorRT path.
1438-1440: Build skipped for PyTorch and AD backends — consistent with bench semantics.No action needed.
1692-1695: Skipping builder metrics for PyTorch/AD — matches build-skip behavior.Log message is clear and backend-aware.
1283-1290: Bench backend switch extended with “_autodeploy” — verify CLI support.Please confirm
trtllm-benchaccepts--backend=_autodeployin this repo/version.Run:
#!/bin/bash # Verify backend choices and AD-specific options in the bench CLI. rg -nP -C3 "(add_argument|ArgumentParser).*--backend" -g '!**/site-packages/**' rg -n "_autodeploy" -C2 rg -n "extra_llm_api_options" -C3 rg -nP "(compile_backend|free_mem_ratio|skip_loading_weights|runtime)" -C2
|
PR_Github #17921 [ run ] completed with state |
|
/bot run |
|
PR_Github #17923 [ run ] triggered by Bot |
|
PR_Github #17923 [ run ] completed with state |
d4d5dbd to
9f21c44
Compare
|
/bot run |
|
PR_Github #17931 [ run ] triggered by Bot |
|
PR_Github #17931 [ run ] completed with state |
|
/bot run |
|
PR_Github #17939 [ run ] triggered by Bot |
|
PR_Github #17939 [ run ] completed with state |
|
/bot run |
|
PR_Github #17982 [ run ] triggered by Bot |
|
PR_Github #17982 [ run ] completed with state |
|
/bot run |
|
PR_Github #18016 [ run ] triggered by Bot |
|
PR_Github #18016 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand.
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --stage-list "H100_PCIe-PyTorch-Perf-1" --test-backend "pytorch" |
|
PR_Github #18047 [ run ] triggered by Bot |
|
PR_Github #18047 [ run ] completed with state |
|
/bot run --disable-reuse-test |
|
PR_Github #18054 [ run ] triggered by Bot |
|
PR_Github #18054 [ run ] completed with state |
|
/bot run |
|
PR_Github #19435 [ run ] triggered by Bot |
|
PR_Github #19435 [ run ] completed with state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the parts related to testing infra, head two questions
9180cbe to
f389a02
Compare
- Added AD backend support in test_perf.py - Added test to l0_perf.yml with proper configuration - Updated performance thresholds and regression handling - Added KV cache metrics and threshold support - Simplified regex handling for KV cache - Removed old AD perf test and trtllm_bench_backend_comparison - Fixed import coding style and various path/param issues Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
284339e to
b5bf18b
Compare
Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
|
/bot run |
|
PR_Github #20178 [ run ] triggered by Bot |
|
PR_Github #20178 [ run ] completed with state |
|
/bot run |
|
PR_Github #20182 [ run ] triggered by Bot |
|
PR_Github #20182 [ run ] completed with state |
… regressions (#8099) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
…t perf regressions (NVIDIA#8099) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>
…nd (#8092) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
…t perf regressions (NVIDIA#8099) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
… backend (NVIDIA#8092) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
…t perf regressions (NVIDIA#8099) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>
… backend (NVIDIA#8092) Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>
Added support for AD in test_perf.py. for AD it fails the test when perf regression detected. On PT it waives the perf regression as it was done so far - no change for PT test behavior.
Removed the old AD perf test which was disabled anyway, and removed it from the yaml files.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.