[None][chore] Enable multiple postprocess workers tests for chat completions api #7602
Conversation
Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughAdds a module-scoped, parameterized pytest fixture to vary post-processing worker counts (0 and 2) and wires it into the OpenAI Harmony test server fixture, passing a corresponding CLI arg array to RemoteOpenAIServer. The server fixture signature is updated to accept the new parameter. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PyTest as pytest
participant NumPP as num_postprocess_workers fixture
participant ServerFix as server fixture
participant Remote as RemoteOpenAIServer
PyTest->>NumPP: Resolve parameter (0 or 2)
NumPP-->>ServerFix: Provide num_postprocess_workers
ServerFix->>ServerFix: Build CLI args with worker count
ServerFix->>Remote: Instantiate with args
Remote-->>ServerFix: Server ready
ServerFix-->>PyTest: Yield server for tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py (2)
1-1: Add the required NVIDIA Apache-2.0 header (2025)Repository guideline requires the header on all .py files.
+# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + import json
210-211: PEP 585 generics break Python 3.8 support
list[str]requires 3.9+. The repo targets 3.8+, so usetyping.List[str].+from typing import List @@ - reasoning_chunks: list[str] = [] - tool_arg_chunks: list[str] = [] + reasoning_chunks: List[str] = [] + tool_arg_chunks: List[str] = []
🧹 Nitpick comments (2)
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py (2)
17-21: Nice param sweep for post-process workers; consider clearer IDsIDs that include the numeric value make CI triage easier.
-@pytest.fixture(scope="module", - params=[0, 2], - ids=["disable_processpool", "enable_processpool"]) +@pytest.fixture(scope="module", + params=[0, 2], + ids=["workers_0_disable", "workers_2_enable"]) def num_postprocess_workers(request): return request.param
7-7: Prefer module-namespace imports per guidelinesKeep class access via module to avoid direct class imports.
-from .openai_server import RemoteOpenAIServer +from . import openai_server @@ - with RemoteOpenAIServer(model_path, args) as remote_server: + with openai_server.RemoteOpenAIServer(model_path, args) as remote_server: @@ -def client(server: RemoteOpenAIServer): +def client(server: openai_server.RemoteOpenAIServer):Also applies to: 28-28, 33-33
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/unittest/llmapi/apps/_test_openai_chat_harmony.py (1)
25-29: Verify--num_postprocess_workersflag acceptance and semantics
Ensure the production server CLI actually defines--num_postprocess_workersand that passing0disables the post‐process worker pool rather than selecting an “auto” or invalid value.
|
PR_Github #17987 [ run ] triggered by Bot |
|
PR_Github #17987 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #18273 [ run ] triggered by Bot |
|
PR_Github #18273 [ run ] completed with state |
|
/bot run |
|
PR_Github #18362 [ run ] triggered by Bot |
|
PR_Github #18362 [ run ] completed with state |
…letions api (NVIDIA#7602) Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>
…letions api (NVIDIA#7602) Signed-off-by: Junyi Xu <219237550+JunyiXu-nv@users.noreply.github.com>
3 participants
Summary by CodeRabbit
Description
This PR is enabling multiple post process workers tests for chat harmony.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.