-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[TRTLLM-7070][feat] add gpt-oss serve benchmark tests #7638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3805933 to
a6b7e35
Compare
b29db90 to
1c75f18
Compare
7f20a30 to
73f79a3
Compare
|
/bot run |
|
Caution Review failedFailed to post review comments. Configuration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
🧰 Additional context used📓 Path-based instructions (3)**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
**/*.py📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-09-09T09:40:45.658ZApplied to files:
📚 Learning: 2025-07-28T17:06:08.621ZApplied to files:
📚 Learning: 2025-08-26T09:49:04.956ZApplied to files:
🧬 Code graph analysis (1)tests/integration/defs/test_e2e.py (2)
🪛 Ruff (0.12.2)tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py51-51: Unused function argument: (ARG001) 62-62: (S603) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
📝 WalkthroughWalkthroughParameterizes TRT-LLM benchmark tests to run for two models, updates E2E wrapper to target specific parametrized inner test, adjusts test lists to enumerate new parameterized cases, enhances unit test to pass server args and assert output, and switches GPU memory skip thresholds from GiB to decimal GB. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor PyTestRunner as PyTest Runner
participant E2E as E2E Wrapper Test
participant Inner as Parametrized Inner Test
participant Server as TRT-LLM Server (fixture)
participant Bench as benchmark_serving.py (subprocess)
PyTestRunner->>E2E: run test_trtllm_benchmark_serving[model_name]
E2E->>Inner: invoke _test_trtllm_serve_benchmark.py::test_trtllm_serve_benchmark[model_name]
activate Inner
Inner->>Server: start with args (kv_cache_free_gpu_memory_fraction=0.8)
activate Server
Server-->>Inner: server ready
Inner->>Bench: run with model arg (derived from model_path)
Bench-->>Inner: exit code, stdout
Inner->>Inner: assert rc==0 and "Serving Benchmark Result" in stdout
deactivate Server
Inner-->>PyTestRunner: test result (per model)
deactivate Inner
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks (1 passed, 2 warnings)❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR_Github #18289 [ run ] triggered by Bot |
|
PR_Github #18289 [ run ] completed with state |
560ba5c to
218f187
Compare
218f187 to
2edb3fd
Compare
|
/bot run |
|
PR_Github #18370 [ run ] triggered by Bot |
|
PR_Github #18370 [ run ] completed with state |
2edb3fd to
9827901
Compare
|
/bot run |
|
PR_Github #18531 [ run ] triggered by Bot |
|
PR_Github #18531 [ run ] completed with state |
|
/bot run H100_PCIe |
|
PR_Github #18548 Bot args parsing error: usage: /bot [-h] |
|
/bot run --gpu-type "H100_PCIe" |
|
PR_Github #18549 [ run ] triggered by Bot |
|
PR_Github #18549 [ run ] completed with state |
9827901 to
25fe2f4
Compare
|
/bot reuse-pipeline |
|
PR_Github #18582 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #18582 [ reuse-pipeline ] completed with state |
3c62b14 to
ce3a5fc
Compare
|
/bot skip --comment "Related H100 tests passed in previous CI" |
ae672cc to
0e26637
Compare
|
/bot reuse-pipeline |
1 similar comment
|
/bot reuse-pipeline |
0e26637 to
ca4d5ff
Compare
|
/bot reuse-pipeline |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
ca4d5ff to
0e712af
Compare
|
/bot reuse-pipeline |
|
PR_Github #18752 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #18752 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
Add gpt-oss trtllm-serve benchmark tests.
The tests are failure due to benchmark script is not stable. https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/view/TRT-LLM-Function-Pipelines/job/DEBUG_LLM_FUNCTION_TEST/1734/testReport/
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.