KEMBAR78
[TRTLLM-7070][feat] add gpt-oss serve benchmark tests by xinhe-nv · Pull Request #7638 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 9, 2025

Summary by CodeRabbit

  • Tests
    • Expanded TRT-LLM serving benchmark to run against two model variants for broader coverage.
    • Refined test selection to target specific parameterized scenarios, improving reliability and clarity of results.
    • Enhanced benchmark assertions to verify successful execution and output presence.
    • Updated GPU memory skip thresholds to decimal GB units, aligning test execution with typical hardware reporting.
    • Adjusted QA test lists to include the new parameterized cases across suites for consistent execution.

Description

Test Coverage

Add gpt-oss trtllm-serve benchmark tests.
The tests are failure due to benchmark script is not stable. https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/view/TRT-LLM-Function-Pipelines/job/DEBUG_LLM_FUNCTION_TEST/1734/testReport/

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@xinhe-nv xinhe-nv force-pushed the user/xinhe/feat branch 2 times, most recently from 3805933 to a6b7e35 Compare September 9, 2025 08:35
@xinhe-nv xinhe-nv force-pushed the user/xinhe/feat branch 3 times, most recently from b29db90 to 1c75f18 Compare September 9, 2025 11:00
@xinhe-nv xinhe-nv marked this pull request as ready for review September 10, 2025 02:26
@xinhe-nv xinhe-nv force-pushed the user/xinhe/feat branch 2 times, most recently from 7f20a30 to 73f79a3 Compare September 10, 2025 02:31
@xinhe-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

Caution

Review failed

Failed to post review comments.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f412f5c and 7f20a30.

📒 Files selected for processing (6)
  • tests/integration/defs/test_e2e.py (1 hunks)
  • tests/integration/test_lists/qa/llm_function_core.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_function_core_sanity.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_function_nim.txt (1 hunks)
  • tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py (3 hunks)
  • tests/unittest/utils/util.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/utils/util.py
  • tests/integration/defs/test_e2e.py
  • tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/utils/util.py
  • tests/integration/defs/test_e2e.py
  • tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/utils/util.py
  • tests/integration/defs/test_e2e.py
  • tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py
🧠 Learnings (4)
📓 Common learnings
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Learnt from: achartier
PR: NVIDIA/TensorRT-LLM#6763
File: tests/integration/defs/triton_server/conftest.py:16-22
Timestamp: 2025-08-11T20:09:24.389Z
Learning: In the TensorRT-LLM test infrastructure, the team prefers simple, direct solutions (like hard-coding directory traversal counts) over more complex but robust approaches when dealing with stable directory structures. They accept the maintenance cost of updating tests if the layout changes.
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/qa/llm_function_core_sanity.txt
  • tests/integration/test_lists/qa/llm_function_nim.txt
  • tests/integration/defs/test_e2e.py
  • tests/integration/test_lists/qa/llm_function_core.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/qa/llm_function_core_sanity.txt
  • tests/integration/test_lists/qa/llm_function_nim.txt
  • tests/integration/defs/test_e2e.py
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/qa/llm_function_core_sanity.txt
  • tests/integration/test_lists/qa/llm_function_nim.txt
  • tests/integration/test_lists/qa/llm_function_core.txt
🧬 Code graph analysis (1)
tests/integration/defs/test_e2e.py (2)
tests/integration/defs/conftest.py (2)
  • llm_venv (715-732)
  • unittest_path (89-90)
tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py (1)
  • model_name (15-16)
🪛 Ruff (0.12.2)
tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py

51-51: Unused function argument: server

(ARG001)


62-62: subprocess call: check for execution of untrusted input

(S603)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
📝 Walkthrough

Walkthrough

Parameterizes TRT-LLM benchmark tests to run for two models, updates E2E wrapper to target specific parametrized inner test, adjusts test lists to enumerate new parameterized cases, enhances unit test to pass server args and assert output, and switches GPU memory skip thresholds from GiB to decimal GB.

Changes

Cohort / File(s) Summary
E2E wrapper parameterization
tests/integration/defs/test_e2e.py
Converts test_trtllm_benchmark_serving to pytest-parametrized over model_name; adjusts signature to (llm_venv, model_name); invokes specific inner test case via path-spec .../_test_trtllm_serve_benchmark.py::test_trtllm_serve_benchmark[{model_name}].
QA test lists updates
tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_core_sanity.txt, tests/integration/test_lists/qa/llm_function_nim.txt
Replaces single test entry with two parametrized entries in core; switches sanity list to [gpt_oss/gpt-oss-20b]; adds [gpt_oss/gpt-oss-20b] entries in nim list.
Inner benchmark test enhancements
tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py
Parameterizes test_trtllm_serve_benchmark over two models with indirect=True; model_name fixture now def model_name(request) returning request.param; server fixture adds CLI arg kv_cache_free_gpu_memory_fraction=0.8; subprocess output captured; asserts return code 0 and stdout contains "Serving Benchmark Result".
GPU memory skip thresholds
tests/unittest/utils/util.py
Changes skip thresholds from GiB (1024-based) to decimal GB (1000-based) for 40, 80, and 138 GB helpers.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor PyTestRunner as PyTest Runner
  participant E2E as E2E Wrapper Test
  participant Inner as Parametrized Inner Test
  participant Server as TRT-LLM Server (fixture)
  participant Bench as benchmark_serving.py (subprocess)

  PyTestRunner->>E2E: run test_trtllm_benchmark_serving[model_name]
  E2E->>Inner: invoke _test_trtllm_serve_benchmark.py::test_trtllm_serve_benchmark[model_name]
  activate Inner
  Inner->>Server: start with args (kv_cache_free_gpu_memory_fraction=0.8)
  activate Server
  Server-->>Inner: server ready
  Inner->>Bench: run with model arg (derived from model_path)
  Bench-->>Inner: exit code, stdout
  Inner->>Inner: assert rc==0 and "Serving Benchmark Result" in stdout
  deactivate Server
  Inner-->>PyTestRunner: test result (per model)
  deactivate Inner
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks (1 passed, 2 warnings)

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The current description retains template placeholders instead of providing an actual summary and leaves the Description section empty, while the Test Coverage section only notes instability without listing specific tests; this omission of substantive content fails to fulfill the required template sections for clear explanation of the issue, solution, and relevant test safeguards. Please replace the @coderabbitai placeholder with a concise summary, fill in the Description section with an explanation of the issue and the implemented solution, and expand the Test Coverage section to list the exact test cases added or modified to ensure adequate coverage.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title “[TRTLLM-7070][feat] add gpt-oss serve benchmark tests” concisely summarizes the primary change by referencing the relevant ticket, specifying the change type, and clearly describing the new benchmark tests being added, which aligns with the project’s guidelines for clear and focused titles.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18289 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18289 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13709 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18370 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18370 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13778 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18531 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18531 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13908 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

/bot run H100_PCIe

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18548 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: H100_PCIe

@xinhe-nv
Copy link
Collaborator Author

/bot run --gpu-type "H100_PCIe"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18549 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18549 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13923 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18582 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18582 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18549 (Partly Tested) for commit 25fe2f4

@xinhe-nv xinhe-nv force-pushed the user/xinhe/feat branch 5 times, most recently from 3c62b14 to ce3a5fc Compare September 16, 2025 02:51
@EmmaQiaoCh
Copy link
Collaborator

/bot skip --comment "Related H100 tests passed in previous CI"

@xinhe-nv xinhe-nv force-pushed the user/xinhe/feat branch 2 times, most recently from ae672cc to 0e26637 Compare September 16, 2025 03:32
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

1 similar comment
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18752 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18752 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18549 (Partly Tested) for commit fdb4668

@xinhe-nv xinhe-nv merged commit 1fbea49 into NVIDIA:main Sep 16, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/xinhe/feat branch September 16, 2025 08:51
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants