[None][ci] move qwen3 tests from GB200 to B200 #7733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
|
/bot run --gpu-type "B200_PCIe,GB200" |
|
PR_Github #18633 [ run ] triggered by Bot |
📝 WalkthroughWalkthroughUpdates Jenkins CI test splits for B200 PCIe PyTorch from 2 to 3 and disables one GB200 PyTorch Slurm test. Expands B200 L0 PyTorch test list, removing a single Qwen3_8B latency test and adding multiple Qwen3_8B and Qwen3_30B_A3B configurations across backends and precisions. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant J as Jenkins L0_Test.groovy
participant LTJ as launchTestJobs()
participant M as Split Matrix
participant Exe as Executor/Slurm
Dev->>J: Trigger L0 pipeline
J->>LTJ: Build test configs (B200, GB200, ...)
LTJ->>M: Expand splits for B200_PCIe-PyTorch
note over M: split_count=3 → split_id: 1,2,3
loop For each split (1..3)
M->>Exe: Enqueue B200_PCIe-PyTorch-[split_id]
end
alt GB200-PyTorch-1 disabled
note over J,Exe: GB200-PyTorch-1 entry commented out → no job created
else Enabled
J->>Exe: Enqueue GB200-PyTorch-1
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chzblych
approved these changes
Sep 15, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(2 hunks)tests/integration/test_lists/test-db/l0_b200.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_b200.yml
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Applied to files:
tests/integration/test_lists/test-db/l0_b200.yml
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/test-db/l0_b200.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/test_lists/test-db/l0_b200.yml (1)
42-53: Confirm Qwen3 B200 additions and single‑GPU memory fit
- Targeted tests exist in tests/integration/defs/accuracy/test_llm_api_pytorch.py — TestQwen3_8B (line 2451), test_w4a8_mxfp4 (2535), TestQwen3_30B_A3B (2553), test_nvfp4 (2634), test_w4a16_mxfp4 (2750).
- Entries added to tests/integration/test_lists/test-db/l0_b200.yml (lines ~41–53); the older TestQwen3_8B::test_fp8_block_scales[latency] remains at line 41 — confirm this is intentional.
- Repo does not include memory/profile data to confirm Qwen3-30B-A3B fits single‑GPU on b100‑ts2 for the selected precisions/backends — verify by running a short latency smoke with the intended activation_dtype/moe_backend or mark the 30B variants as multi‑GPU if they OOM.
jenkins/L0_Test.groovy (1)
2036-2038: B200 PyTorch split expanded to 3 — cannot verify historical runtimes; confirm capacity & balanceVerification script returned no matching JUnit result files; historical wall times could not be computed.
Change: jenkins/L0_Test.groovy:2036–2038
- Capacity: ensure b100-ts2 has ≥3 available executors so the three splits can run concurrently without starving other pools (check Jenkins nodes/label pool or autoscale config).
- Runtimes: confirm per-split average and 95th‑percentile wall time remain within the existing stage timeout. To summarize recent JUnit results locally, run:
python - <<'PY' import glob,re,statistics files=glob.glob('**/results*B200_PCIe-PyTorch*.xml',recursive=True)[-30:] for f in files: s=open(f).read() times=[float(x) for x in re.findall(r'<testsuite[^>]*time="([0-9.]+)"',s)] print("==",f,"==") if times: times.sort() n=len(times) p95=times[int(0.95*n)-1] if n>0 else 0 print(f"sum={sum(times):.2f} count={n} avg={statistics.mean(times):.2f} p95={p95:.2f}") else: print("no times found") PYReturn the per-split avg and p95 plus current free executor count for b100-ts2 to re-check.
|
/bot run --gpu-type "B200_PCIe,GB200" |
|
PR_Github #18640 [ run ] triggered by Bot |
|
PR_Github #18633 [ run ] completed with state |
|
PR_Github #18640 [ run ] completed with state |
|
/bot skip --comment "B200 pipelines passed" |
|
PR_Github #18672 [ skip ] triggered by Bot |
|
PR_Github #18672 [ skip ] completed with state |
Wong4j
pushed a commit
to Wong4j/TensorRT-LLM
that referenced
this pull request
Sep 20, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
MrGeva
pushed a commit
to nv-auto-deploy/TensorRT-LLM
that referenced
this pull request
Sep 21, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.