[TRTLLM-6741][fix] Add heuristics for lm head tp size when enable_lm_head_tp_in_adp=True
#7891
Conversation
Njuapp
force-pushed
the
lm_tp_prototype
branch
from
0721b49 to
f8c04fa
Compare
Njuapp
changed the title
enable_lm_head_tp_in_adp to prototypeenable_lm_head_tp_in_adp to prototype
Njuapp
changed the title
enable_lm_head_tp_in_adp to prototypeenable_lm_head_tp_in_adp to prototype
Njuapp
changed the title
enable_lm_head_tp_in_adp to prototypeenable_lm_head_tp_in_adp to prototype
📝 WalkthroughWalkthroughUpdated metadata in BaseLlmArgs within tensorrt_llm/llmapi/llm_args.py: changed enable_lm_head_tp_in_adp field status from "beta" to "prototype" and added "prototype" status to the cp_config field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tensorrt_llm/llmapi/llm_args.py (1)
1283-1286: Markcp_configas prototype — fix Optional vs {} semantics.Status addition is fine. The Field is annotated Optional[dict] but uses default_factory=dict (runtime default {}); repo call sites mostly treat cp_config as a dict (many .get / 'in' uses). mapping(...) still accepts None and checks
cp_config is None(tensorrt_llm/mapping.py:135) but mapping.init normalizes None -> {} (tensorrt_llm/mapping.py:218). Change tensorrt_llm/llmapi/llm_args.py (Field at ~1283) to a non-optional dict (e.g. dict[str, Any]) to match runtime behavior — or make the Field default None and audit callers if you need distinct None semantics.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tensorrt_llm/llmapi/llm_args.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/llmapi/llm_args.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/llmapi/llm_args.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/llmapi/llm_args.py
🧠 Learnings (1)
📓 Common learnings
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
🔇 Additional comments (1)
tensorrt_llm/llmapi/llm_args.py (1)
1278-1282: Approve — enable_lm_head_tp_in_adp downgraded to prototype; docs/tests synced.
Status is "prototype" in tensorrt_llm/llmapi/llm_args.py and in tests/unittest/api_stability/references/llm.yaml; no remaining "beta" mentions for this knob found.
Njuapp
changed the title
enable_lm_head_tp_in_adp to prototypeenable_lm_head_tp_in_adp=True
|
/bot run |
|
PR_Github #20097 [ run ] triggered by Bot |
|
PR_Github #20097 [ run ] completed with state |
Signed-off-by: Cheng Hang <chang@nvidia.com>
Njuapp
force-pushed
the
lm_tp_prototype
branch
from
b743205 to
5a5ccd9
Compare
|
/bot run |
|
PR_Github #20134 [ run ] triggered by Bot |
|
PR_Github #20134 [ run ] completed with state |
|
/bot run |
|
PR_Github #20145 [ run ] triggered by Bot |
|
PR_Github #20217 [ run ] triggered by Bot |
|
PR_Github #20206 [ run ] completed with state |
|
PR_Github #20218 [ run ] triggered by Bot |
|
PR_Github #20217 [ run ] completed with state |
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Cheng Hang <chang@nvidia.com>
|
PR_Github #20218 [ run ] completed with state |
|
/bot run |
|
PR_Github #20228 [ run ] triggered by Bot |
|
PR_Github #20228 [ run ] completed with state |
|
/bot run |
|
PR_Github #20238 [ run ] triggered by Bot |
|
PR_Github #20238 [ run ] completed with state |
|
/bot run |
|
PR_Github #20245 [ run ] triggered by Bot |
|
PR_Github #20245 [ run ] completed with state |
|
/bot run |
|
PR_Github #20255 [ run ] triggered by Bot |
|
PR_Github #20255 [ run ] completed with state |
Head branch was pushed to by a user without write access
|
/bot run |
|
PR_Github #20278 [ run ] triggered by Bot |
|
PR_Github #20278 [ run ] completed with state |
…_head_tp_in_adp=True` (NVIDIA#7891) Signed-off-by: Cheng Hang <chang@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>
8 participants
Add heuristics for lm head tp size, and changed llm flags of
enable_lm_head_tp_in_adptoprototypeDescription
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit