[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests #8069

pcastonguay · 2025-09-29T16:59:38Z

Summary by CodeRabbit

Tests
- Re-enabled previously skipped accuracy tests for Llama 3.1 8B Instruct under disaggregated serving with context parallelism 4 and gen_tp configurations 1 and 2.
- Improves test coverage and validation for MMLU scenarios, ensuring these configurations are actively verified in CI.
- Removes waivers that previously excluded these cases from execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>

pcastonguay · 2025-09-29T16:59:51Z

/bot run --disable-fail-fast

coderabbitai · 2025-09-29T17:02:09Z

📝 Walkthrough

Walkthrough

Removed two SKIP entries from the test waiver list so the specified tests will run.

Changes

Cohort / File(s)	Summary
Test waiver updates `tests/integration/test_lists/waives.txt`	Removed 2 SKIP entries for accuracy/disaggregated serving tests (MMLU with gen_tp=2, ctx_pp=4 and gen_tp=1, ctx_pp=4) tied to nvbugs/5434320.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description remains unfilled beyond the template placeholders and lacks the required summary, explanation of the issue and its resolution, and details on test coverage. Without any substantive content replacing the placeholder template sections, the description does not meet the repository’s requirements for a complete pull request description.	Please complete the description by adding a concise summary of the changes, clearly explaining the problem and the solution, and listing the relevant tests that validate this fix, ensuring all template sections are appropriately filled.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests” follows the repository’s ticket-and-type template and clearly highlights the main change of re-enabling the disaggregated pipeline parallel tests by removing their skips. It concisely reflects the core purpose of the pull request, enabling reviewers to quickly understand the fix without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 334e2ca and e0835f9.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-09-29T17:05:05Z

PR_Github #20288 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-29T20:43:34Z

PR_Github #20288 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15299 completed with status: 'FAILURE'

pcastonguay · 2025-09-30T18:55:14Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-09-30T19:01:19Z

PR_Github #20409 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-30T20:47:34Z

PR_Github #20409 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15400 completed with status: 'SUCCESS'

…8069) Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>

…8069) Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>

…8069) Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>

fix: Unwaiving disagg pp tests

e0835f9

Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>

pcastonguay requested a review from Tabrizian September 29, 2025 16:59

Tabrizian approved these changes Sep 29, 2025

View reviewed changes

Tabrizian mentioned this pull request Sep 29, 2025

[None][fix] unwaive tests #8046

Open

1 task

Tabrizian merged commit b77f19f into NVIDIA:main Oct 1, 2025
8 of 9 checks passed

evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Oct 3, 2025

[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests (NVIDIA#…

eeaf8a4

…8069) Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests #8069

[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests #8069

Uh oh!

pcastonguay commented Sep 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

pcastonguay commented Sep 29, 2025

Uh oh!

coderabbitai bot commented Sep 29, 2025

Walkthrough

Changes

Estimated code review effort

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

pcastonguay commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests #8069

[https://nvbugs/5434320][fix] fix: Unwaiving disagg pp tests #8069

Uh oh!

Conversation

pcastonguay commented Sep 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

pcastonguay commented Sep 29, 2025

Uh oh!

coderabbitai bot commented Sep 29, 2025

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

pcastonguay commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pcastonguay commented Sep 29, 2025 •

edited by coderabbitai bot

Loading