[TRTLLM-6239][feat] add test cases into QA test list #8081

xinhe-nv · 2025-09-30T01:39:35Z

Summary by CodeRabbit

Tests
- Expanded integration coverage with a new chat interaction scenario and KV cache timing checks across disaggregated variants.
- Included the new scenario in standard, sanity, and NIM test groups to broaden validation and catch regressions earlier.
- No changes to product behavior; improvements focus on reliability and confidence in releases.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

xinhe-nv · 2025-09-30T01:40:57Z

/bot run --skip-test

coderabbitai · 2025-09-30T01:41:25Z

📝 Walkthrough

Walkthrough

Updated QA integration test list files by appending new test identifiers, including test_e2e.py::test_openai_chat_harmony and additional disaggregated kv_cache_time_output entries. No removals or logic changes. One file includes the same test identifier twice.

Changes

Cohort / File(s)	Summary
QA test list updates `tests/integration/test_lists/qa/llm_function_core.txt`, `tests/integration/test_lists/qa/llm_function_core_sanity.txt`, `tests/integration/test_lists/qa/llm_function_nim.txt`	- core: added test_e2e.py::test_openai_chat_harmony and multiple disaggregated::kv_cache_time_output entries (incl. TinyLlama-1.1B-Chat-v1.0). - core_sanity: appended test_e2e.py::test_openai_chat_harmony. - nim: added test_e2e.py::test_openai_chat_harmony (inserted twice).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description follows the template structure but does not include any actual content in the Description or Test Coverage sections, leaving only placeholder comments and failing to summarize what was changed or which tests safeguard the changes.	Please replace the placeholder comments under the Description and Test Coverage headings with a clear summary of the changes and a list of the relevant tests added, ensuring the PR description accurately documents the work.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title concisely reflects the primary change of adding new test cases to the QA test lists and matches the modifications shown in the diff without extraneous details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62010c0 and 4cc3f1d.

📒 Files selected for processing (3)

tests/integration/test_lists/qa/llm_function_core.txt (2 hunks)
tests/integration/test_lists/qa/llm_function_core_sanity.txt (1 hunks)
tests/integration/test_lists/qa/llm_function_nim.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-09T09:40:45.658Z

Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

tests/integration/test_lists/qa/llm_function_core.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (4)

tests/integration/test_lists/qa/llm_function_nim.txt (1)

176-176: LGTM!

The test identifier is correctly formatted and appropriately placed. The addition of test_openai_chat_harmony to the NIM function test list aligns with the PR objective of expanding QA test coverage.

tests/integration/test_lists/qa/llm_function_core_sanity.txt (1)

210-210: LGTM!

The test identifier is correctly formatted and appropriately placed in the sanity test list. This addition is consistent with the broader PR objective of expanding test coverage across different QA test categories.

Based on learnings

tests/integration/test_lists/qa/llm_function_core.txt (2)

625-625: LGTM!

The test identifier is correctly formatted and appropriately placed in the core test list. This completes the addition of test_openai_chat_harmony across all three QA test list files, providing comprehensive test coverage.

749-749: LGTM!

The disaggregated test identifier is correctly formatted with proper parameterization for the TinyLlama model. The placement within the disaggregated test section is appropriate and aligns with the PR's objective of expanding test coverage.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-09-30T01:47:03Z

PR_Github #20313 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-30T03:33:10Z

PR_Github #20313 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15321 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>

xinhe-nv · 2025-09-30T03:52:14Z

/bot reuse-pipeline

tensorrt-cicd · 2025-09-30T03:57:43Z

PR_Github #20325 [ reuse-pipeline ] triggered by Bot

tensorrt-cicd · 2025-09-30T04:23:44Z

PR_Github #20325 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20313 (Partly Tested) for commit 57c2be2

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> Signed-off-by: Faradawn Yang <faradawny@gmail.com>

xinhe-nv requested review from LarryXFly, StanleySun639 and crazydemo September 30, 2025 01:39

xinhe-nv force-pushed the hex-1.1 branch from a5cc148 to 4cc3f1d Compare September 30, 2025 01:39

xinhe-nv enabled auto-merge (squash) September 30, 2025 01:41

crazydemo approved these changes Sep 30, 2025

View reviewed changes

xinhe-nv force-pushed the hex-1.1 branch from 4cc3f1d to 89c4072 Compare September 30, 2025 03:04

add test cases into qa test list

57c2be2

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>

xinhe-nv force-pushed the hex-1.1 branch from 89c4072 to 57c2be2 Compare September 30, 2025 03:37

xinhe-nv merged commit 1dba9fa into NVIDIA:main Sep 30, 2025
5 checks passed

xinhe-nv deleted the hex-1.1 branch September 30, 2025 04:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TRTLLM-6239][feat] add test cases into QA test list #8081

[TRTLLM-6239][feat] add test cases into QA test list #8081

Uh oh!

xinhe-nv commented Sep 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

xinhe-nv commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

xinhe-nv commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TRTLLM-6239][feat] add test cases into QA test list #8081

[TRTLLM-6239][feat] add test cases into QA test list #8081

Uh oh!

Conversation

xinhe-nv commented Sep 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

xinhe-nv commented Sep 30, 2025

Uh oh!

coderabbitai bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

xinhe-nv commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

tensorrt-cicd commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xinhe-nv commented Sep 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 30, 2025 •

edited

Loading