KEMBAR78
[None][chore] Remove closed bugs by xinhe-nv · Pull Request #8151 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

[None][chore] Remove closed bugs #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

[None][chore] Remove closed bugs #8151

merged 1 commit into from
Oct 10, 2025

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 5, 2025 •
edited by coderabbitai bot
Loading

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Cleaned up integration test waivers by removing obsolete and duplicated skips, aligning the suite with current behavior and reducing noise in CI.
    • This test-only maintenance improves signal quality, makes failures more visible, and streamlines triage for developers.
    • No changes to product functionality, performance, or APIs.

@xinhe-nv xinhe-nv marked this pull request as ready for review October 9, 2025 01:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

📝 Walkthrough

Walkthrough

The pull request modifies a single test configuration file by removing multiple SKIP/waiver entries from tests/integration/test_lists/waives.txt. No source code, APIs, or runtime logic are changed.

Changes

Cohort / File(s) Summary
Test waivers cleanup
tests/integration/test_lists/waives.txt		 Removed multiple SKIP/waiver lines from the integration test waives list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not follow the repository’s required template: it lacks the header sections for Description, Test Coverage, and PR Checklist (and the @coderabbitai summary), providing only a one-line statement without context or details. Please update the PR description to include the template’s sections—Description, Test Coverage, and PR Checklist—provide a summary of the change and rationale, and list relevant tests and checklist items to ensure completeness.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[None][chore] Remove closed bugs” accurately reflects the main change of removing closed bug entries from the waives file and follows the repository’s ticket and type formatting guidelines. It is concise, clear, and directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8060aad and 6cadf86.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251005 branch 2 times, most recently from 4237098 to c783eaa Compare October 9, 2025 01:27
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 9, 2025 01:27
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Oct 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20830 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251005 branch from c783eaa to 704613e Compare October 9, 2025 01:42
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20830 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15750 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251005 branch 2 times, most recently from 3c279e6 to 74a57ba Compare October 9, 2025 03:06
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Oct 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20848 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20848 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15766 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251005 branch from 249da74 to 2f4a487 Compare October 10, 2025 01:34
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20941 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20941 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15841 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv
unwaive closed tests
aab82cd 
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251005 branch from 2f4a487 to aab82cd Compare October 10, 2025 03:25
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20959 [ run ] triggered by Bot

@LarryXFly LarryXFly disabled auto-merge October 10, 2025 05:39
@LarryXFly LarryXFly merged commit e8c9bae into NVIDIA:main Oct 10, 2025
4 of 5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20251005 branch October 10, 2025 05:42
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20959 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15853 (Partly Tested) completed with status: 'SUCCESS'

@coderabbitai coderabbitai bot mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazydemo crazydemo crazydemo approved these changes

@LarryXFly LarryXFly LarryXFly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinhe-nv @tensorrt-cicd @crazydemo @LarryXFly