KEMBAR78
[None][ci] pin flashinfer-python version by QiJune · Pull Request #8217 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@QiJune
Copy link
Collaborator

@QiJune QiJune commented Oct 9, 2025

Summary by CodeRabbit

  • Chores
    • Tightened the version range for a core dependency to the 0.3.x series, preventing automatic upgrades to 0.4.x.
    • Improves compatibility and reduces unexpected breakages during installs or updates.
    • Ensures more predictable installations across environments and CI.
    • No user-facing functionality changed.
    • No action required unless you explicitly depend on 0.4.x features.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Copy link
Collaborator Author

QiJune commented Oct 9, 2025

/bot run --stage-list "A10-PackageSanityCheck-PY310-UB2204-CU12"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

📝 Walkthrough

Walkthrough

Updated the dependency constraint in requirements.txt for flashinfer-python from >=0.3.0 to >=0.3.0,<0.4.0. No other files or code paths changed.

Changes

Cohort / File(s) Summary
Dependency constraint update
requirements.txt
Tightened version range for flashinfer-python to >=0.3.0,<0.4.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description consists solely of the unfilled template with placeholders and lacks a proper title, a filled Description section, and any Test Coverage details as required by the repository’s description template. Without a formatted “[ticket][type] Summary” title or explanation of the change’s purpose and test safeguards, reviewers cannot assess the intent or validity of the update. Therefore the description check fails. Please update the PR description to include a title that follows the “[JIRA ticket/NVBugs ID/GitHub issue/None][type] Summary” format, complete the Description section with an explanation of why the flashinfer-python version is being pinned, and provide a Test Coverage section listing relevant tests. Ensure the PR checklist items are addressed and any new dependencies are scanned for license and vulnerabilities so that reviewers can fully understand and verify the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[None][ci] pin flashinfer-python version” succinctly follows the repository’s ticket and type format and accurately summarizes the key change of tightening the flashinfer-python dependency constraint without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20860 [ run ] triggered by Bot

@chzblych chzblych enabled auto-merge (squash) October 9, 2025 08:54
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20860 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15777 (Partly Tested) completed with status: 'SUCCESS'

@QiJune
Copy link
Collaborator Author

QiJune commented Oct 9, 2025

/bot skip --comment "A10-PackageSanityCheck-PY310-UB2204-CU12 passed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20878 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20878 [ skip ] completed with state SUCCESS
Skipping testing for commit e5ffe84

@chzblych chzblych merged commit e101213 into NVIDIA:main Oct 9, 2025
8 of 9 checks passed
ZhanruiSunCh pushed a commit to ZhanruiSunCh/TensorRT-LLM that referenced this pull request Oct 10, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Superjomn pushed a commit that referenced this pull request Oct 10, 2025
…8252)

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Co-authored-by: QI JUN <22017000+QiJune@users.noreply.github.com>
rosenrodt pushed a commit to rosenrodt/TensorRT-LLM that referenced this pull request Oct 13, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
rosenrodt pushed a commit to rosenrodt/TensorRT-LLM that referenced this pull request Oct 13, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: Anthony Chang <27950904+rosenrodt@users.noreply.github.com>
kris1025 pushed a commit to kris1025/TensorRT-LLM that referenced this pull request Oct 14, 2025
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants