[TRTLLM-8580][test] save runtime report periodically #8312
Conversation
crazydemo
force-pushed
the
save_runtime_report
branch
from
4f11560 to
ab09462
Compare
crazydemo
force-pushed
the
save_runtime_report
branch
2 times, most recently
from
105828b to
e18c944
Compare
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
crazydemo
force-pushed
the
save_runtime_report
branch
from
248fdf7 to
1e8f723
Compare
📝 WalkthroughWalkthroughIntroduces a new pytest reporter (PeriodicJUnitXML) that batches test reports and periodically writes JUnit XML. Integrates via conftest with new CLI options to enable and configure interval and batch size. Exposes the reporter through the utils package’s public API and wires optional signal-based flushing. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Pytest as Pytest Runner
participant Conftest as conftest.py
participant Reporter as PeriodicJUnitXML
participant LogXML as pytest LogXML
participant FS as Filesystem
participant OS as OS Signals
Pytest->>Conftest: Parse CLI options
Conftest->>Reporter: Instantiate if --periodic-junit enabled
Pytest->>Reporter: pytest_configure(config)
Reporter->>Reporter: Register signal handlers
Note over Reporter: Lazy init of LogXML on first use
loop For each test phase
Pytest->>Reporter: pytest_runtest_logreport(report)
Reporter->>Reporter: Buffer report<br/>Process when batch size met
alt Batch ready or interval elapsed
Reporter->>LogXML: Append processed reports
LogXML->>FS: Write XML to temp
FS-->>LogXML: Temp written
LogXML->>FS: Atomic rename to target
end
end
OS-->>Reporter: SIGINT/SIGTERM
Reporter->>Reporter: Flush pending reports
Reporter->>LogXML: Generate XML
LogXML->>FS: Atomic write
Pytest->>Reporter: pytest_sessionfinish()
Reporter->>Reporter: Final flush
Reporter->>LogXML: Final XML generation
LogXML->>FS: Atomic write
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
tests/integration/defs/utils/periodic_junit.py (2)
181-191: Narrow exception handling and include error detailsCatching bare Exception multiple times hides specific failures. Prefer narrower exceptions (e.g., OSError for I/O) and include more context (e.g., traceback).
- Replace broad catches where feasible (I/O paths) with OSError.
- When keeping broad catches for resilience, log with traceback to aid debugging.
Example adjustment:
import traceback ... except OSError as e: self._log_warning(f"Filesystem error during report generation: {e}") except Exception: self._log_warning(f"Unexpected error:\n{traceback.format_exc()}")As per coding guidelines and static analysis hints
Also applies to: 283-291, 322-325
296-334: Minor: mark unused signal handler frame parameterTo silence linters and clarify intent, prefix the unused argument with underscore.
- def signal_handler(signum, frame): + def signal_handler(signum, _frame):
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
tests/integration/defs/conftest.py(3 hunks)tests/integration/defs/utils/__init__.py(1 hunks)tests/integration/defs/utils/periodic_junit.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/integration/defs/utils/__init__.pytests/integration/defs/conftest.pytests/integration/defs/utils/periodic_junit.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/integration/defs/utils/__init__.pytests/integration/defs/conftest.pytests/integration/defs/utils/periodic_junit.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/integration/defs/utils/__init__.pytests/integration/defs/conftest.pytests/integration/defs/utils/periodic_junit.py
🧬 Code graph analysis (3)
tests/integration/defs/utils/__init__.py (1)
tests/integration/defs/utils/periodic_junit.py (1)
PeriodicJUnitXML(41-341)
tests/integration/defs/conftest.py (2)
tests/integration/defs/utils/periodic_junit.py (2)
PeriodicJUnitXML(41-341)pytest_configure(120-137)tests/integration/defs/trt_test_alternative.py (2)
print_info(300-306)print_warning(309-315)
tests/integration/defs/utils/periodic_junit.py (1)
tests/integration/defs/conftest.py (1)
pytest_configure(2221-2261)
🪛 Ruff (0.14.0)
tests/integration/defs/conftest.py
2253-2253: f-string without any placeholders
Remove extraneous f prefix
(F541)
tests/integration/defs/utils/periodic_junit.py
182-182: Do not catch blind exception: Exception
(BLE001)
190-190: Do not catch blind exception: Exception
(BLE001)
289-290: try-except-pass detected, consider logging the exception
(S110)
289-289: Do not catch blind exception: Exception
(BLE001)
296-296: Unused function argument: frame
(ARG001)
322-322: Do not catch blind exception: Exception
(BLE001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/defs/utils/__init__.py (1)
22-22: Public API exposure looks goodImport and all entry for PeriodicJUnitXML are consistent and ready for use.
Also applies to: 27-30
tests/integration/defs/conftest.py (1)
2099-2125: CLI options are well-scoped and typedOptions names, help, and typing look correct and align with the reporter’s API.
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
|
/bot run |
|
PR_Github #21526 [ run ] triggered by Bot |
|
PR_Github #21526 [ run ] completed with state |
|
/bot run |
|
PR_Github #21551 [ run ] triggered by Bot |
|
PR_Github #21551 [ run ] completed with state |
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
…VIDIA#8455) Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
4 participants
This feature now is only enabled in tests/integration/defs/conftest.py, should not affect L0 test currently.
verified locally, no obvious time overhead is detected.
only one results.xml will be generated.
Summary by CodeRabbit
New Features
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.