[TRTLLM-8480][chore] clean create_py_executor API #8412
Conversation
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
📝 WalkthroughWalkthroughThis change removes LoraConfig and KvCacheConnectorConfig as publicly passed parameters across executor creation and worker layers. These configs are now derived from llm_args where needed. Signatures and imports are updated accordingly across executor factories, proxies, workers, RPC/Ray components, and Torch py executor creator. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant GenExec as GenerationExecutor
participant Proxy as Proxy/Executor Impl
participant Worker as Worker
participant TorchPy as Torch PyExecutor Creator
Note over Caller,Worker: Before: lora_config & kv_connector_config passed explicitly through layers
Caller->>GenExec: create(engine, ..., lora_config, kv_connector_config, llm_args)
GenExec->>Proxy: init(worker_kwargs + lora/kv)
Proxy->>Worker: init(..., lora_config, kv_connector_config)
Worker->>TorchPy: create_py_executor(..., lora_config, kv_connector_config)
TorchPy-->>Worker: executor
Worker-->>Proxy: ready
Proxy-->>GenExec: executor
GenExec-->>Caller: handle
rect rgba(240,248,255,0.6)
Note over Caller,Worker: After: configs sourced from llm_args only
Caller->>GenExec: create(engine, ..., llm_args)
GenExec->>Proxy: init(worker_kwargs without lora/kv)
Proxy->>Worker: init(..., llm_args)
Worker->>TorchPy: create_py_executor(..., llm_args)
TorchPy->>TorchPy: derive lora/kv from llm_args
TorchPy-->>Worker: executor
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
**/*.py📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Files:
🧠 Learnings (2)📚 Learning: 2025-08-26T06:07:02.166ZApplied to files:
📚 Learning: 2025-08-26T09:37:10.463ZApplied to files:
🧬 Code graph analysis (4)tensorrt_llm/executor/rpc_worker.py (1)
tensorrt_llm/_torch/pyexecutor/py_executor_creator.py (2)
tensorrt_llm/executor/executor.py (6)
tensorrt_llm/executor/base_worker.py (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/bot run |
|
PR_Github #21521 [ run ] triggered by Bot |
|
/bot run |
|
PR_Github #21521 [ run ] completed with state |
|
PR_Github #21544 [ run ] triggered by Bot |
|
PR_Github #21544 [ run ] completed with state |
|
/bot run |
|
PR_Github #21634 [ run ] triggered by Bot |
|
PR_Github #21634 [ run ] completed with state |
|
/bot run |
|
PR_Github #21652 [ run ] triggered by Bot |
|
PR_Github #21652 [ run ] completed with state |
|
/bot run |
|
PR_Github #21698 [ run ] triggered by Bot. Commit: |
|
PR_Github #21698 [ run ] completed with state |
|
/bot skip --comment "only one unrelated AsymmetricalCacheTest failed" |
|
PR_Github #21744 [ skip ] triggered by Bot. Commit: |
|
PR_Github #21744 [ skip ] completed with state |
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
5 participants
Summary by CodeRabbit
Refactor
Documentation
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.