[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels setup #8438

venkywonka · 2025-10-16T17:36:21Z

Summary by CodeRabbit

Chores
- Updated package configuration to ensure license and attribution files are properly included in distributions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…ate setup.py to include license file in package distribution. Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

…update setup.py to include it in the package distribution alongside existing license files. Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

coderabbitai · 2025-10-16T17:36:55Z

📝 Walkthrough

Walkthrough

Added license_files parameter to the setup() function in setup.py, specifying three license and attribution files (LICENSE, ATTRIBUTIONS-CPP.md, ATTRIBUTIONS-Python.md) as packaging metadata.

Changes

Cohort / File(s)	Summary
Packaging metadata `setup.py`	Added `license_files` parameter to `setup()` invocation, explicitly declaring license and attribution files for package distribution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description fails to meet the template requirements as the author has submitted the PR without filling out the critical sections. The PR title remains as a placeholder "[None] @coderabbitai title" instead of being properly formatted, the Description section is completely empty with only the template comment remaining, and the Test Coverage section contains no information about relevant tests. While the PR Checklist checkbox is marked, no supporting details or explanations are provided about how the review items were addressed. The raw summary indicates the changes add license files metadata to setup.py, but this context is entirely absent from the PR description itself.	The author must provide a proper pull request description by filling out all required template sections. Specifically, update the PR title to follow the format "[None][chore] Add license_files to setup.py", write a clear Description explaining what files are being added and why, provide Test Coverage information confirming the packaging changes work correctly, and complete the PR Checklist with actual evidence of review rather than just checking the final box. The empty Description and Test Coverage sections make it impossible to understand the rationale and validation of this change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The PR title `[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels setup` accurately reflects the main change in the changeset, which is adding three license-related files (LICENSE, ATTRIBUTIONS-CPP.md, ATTRIBUTIONS-Python.md) to the license_files parameter in setup.py. The title follows the required template format with ticket identifier [None], type [chore], and a clear summary. The use of curly brace notation {CPP,Python} is a reasonable compact representation of the two new attribution files being added, and the phrase "Update in wheels setup" correctly indicates the change is in the packaging metadata.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

setup.py

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka · 2025-10-16T20:18:55Z

/bot run --skip-test --comment "will only run test_pip_install.py along with doc and sanity checks"

tensorrt-cicd · 2025-10-16T20:27:26Z

PR_Github #21612 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --comment will only run test_pip_install.py along with doc and sanity checks

venkywonka · 2025-10-16T20:28:23Z

/bot run --skip-test

tensorrt-cicd · 2025-10-16T20:34:30Z

PR_Github #21613 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-16T22:09:21Z

PR_Github #21613 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16284 (Partly Tested) completed with status: 'FAILURE'

venkywonka · 2025-10-16T22:32:45Z

/bot run --skip-test

tensorrt-cicd · 2025-10-16T22:38:27Z

PR_Github #21621 [ run ] triggered by Bot

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka · 2025-10-16T22:48:30Z

/bot run --skip-test

tensorrt-cicd · 2025-10-16T22:54:30Z

PR_Github #21622 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-16T22:54:31Z

PR_Github #21621 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #16290 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd · 2025-10-17T00:01:02Z

PR_Github #21622 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16291 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka · 2025-10-17T00:48:44Z

/bot run --skip-test

tensorrt-cicd · 2025-10-17T00:56:54Z

PR_Github #21633 [ run ] triggered by Bot

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka · 2025-10-17T01:57:27Z

/bot run --skip-test

tensorrt-cicd · 2025-10-17T02:03:00Z

PR_Github #21642 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-17T02:03:02Z

PR_Github #21633 [ run ] completed with state ABORTED
/LLM/main/L0_MergeRequest_PR pipeline #16300 (Partly Tested) completed with status: 'FAILURE'

tensorrt-cicd · 2025-10-17T04:06:17Z

PR_Github #21642 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16307 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

venkywonka · 2025-10-17T12:55:26Z

/bot skip --comment "no L0 coverage for this. Verified attribution is included in wheel manually."

tensorrt-cicd · 2025-10-17T13:01:45Z

PR_Github #21703 [ skip ] triggered by Bot. Commit: 43c49e4

tensorrt-cicd · 2025-10-17T13:33:03Z

PR_Github #21703 [ skip ] completed with state SUCCESS. Commit: 43c49e4
Skipping testing for commit 43c49e4

MartinMarciniszyn · 2025-10-20T07:40:18Z

setup.py

    package_data={
        'tensorrt_llm': package_data,
    },
+    license_files=["LICENSE", "ATTRIBUTIONS-CPP.md"],


@venkywonka , do we not need to add ATTRIBUTIONS-Python.md" here?

yea we don't have to, apparently because we don't "distribute it" as part of our binaries - the user installs the python packages in their runtime outside our the wheel we ship. cc @tburt-nv

…tup (NVIDIA#8438) Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka added 2 commits October 16, 2025 10:29

Add ATTRIBUTIONS-CPP.md for third-party software attributions and upd…

9866110

…ate setup.py to include license file in package distribution. Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

Add ATTRIBUTIONS-Python.md for third-party software attributions and …

0385fa7

…update setup.py to include it in the package distribution alongside existing license files. Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

venkywonka self-assigned this Oct 16, 2025

venkywonka requested a review from a team as a code owner October 16, 2025 17:36

venkywonka mentioned this pull request Oct 16, 2025

[TRTLLM-7964][infra] Set nixl to default cache transceiver backend #7926

Merged

1 task

coderabbitai bot changed the title ~~[None] @coderabbitai title~~ [None] [chore] Add license_files to setup configuration Oct 16, 2025

venkywonka changed the title ~~[None] [chore] Add license_files to setup configuration~~ [None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update package in wheels Oct 16, 2025

venkywonka changed the title ~~[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update package in wheels~~ [None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels setup Oct 16, 2025

venkywonka requested review from atrifex, juney-nvidia, schetlur-nv, tburt-nv, tongyuantongyu and yuanjingx87 October 16, 2025 17:41

tburt-nv reviewed Oct 16, 2025

View reviewed changes

setup.py Outdated Show resolved Hide resolved

venkywonka added 2 commits October 16, 2025 11:15

remove python attribs, add test

12a0222

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

codespell ignore

d7d80f8

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

add force-reinstall to make sure the wheel is installed

687de1d

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

try --no-deps maybe

b2b6a94

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

revert test as stale wheel is used

43c49e4

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

juney-nvidia approved these changes Oct 17, 2025

View reviewed changes

juney-nvidia enabled auto-merge (squash) October 17, 2025 12:53

juney-nvidia merged commit 8d07580 into NVIDIA:main Oct 17, 2025
5 checks passed

coderabbitai bot mentioned this pull request Oct 17, 2025

[None] [chore] Add architecture-specific ATTRIBUTIONS files #8468

Merged

1 task

MartinMarciniszyn reviewed Oct 20, 2025

View reviewed changes

govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025

[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels se…

da2b180

…tup (NVIDIA#8438) Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>

[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels setup #8438

[None] [chore] Add ATTRIBUTIONS-{CPP,Python}.md + Update in wheels setup #8438

Conversation

venkywonka commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

venkywonka commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

venkywonka commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

venkywonka commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

venkywonka commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

venkywonka commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

venkywonka commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

venkywonka commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

tensorrt-cicd commented Oct 17, 2025

Uh oh!

Uh oh!

MartinMarciniszyn Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

venkywonka Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

venkywonka commented Oct 16, 2025 •

edited

Loading

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

venkywonka Oct 22, 2025 •

edited

Loading