KEMBAR78
Drop Thrust's cpp_compatibility.h by bernhardmgruber · Pull Request #3746 · NVIDIA/cccl · GitHub
Skip to content

Drop Thrust's cpp_compatibility.h #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Drop Thrust's cpp_compatibility.h #3746

merged 1 commit into from
Feb 7, 2025

Conversation

@bernhardmgruber
Copy link
Contributor

No description provided.

@bernhardmgruber bernhardmgruber requested review from a team as code owners February 7, 2025 17:04
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. breaking Breaking change labels Feb 7, 2025
@bernhardmgruber bernhardmgruber mentioned this pull request Feb 7, 2025
Closed
86 tasks
@miscco miscco enabled auto-merge (squash) February 7, 2025 18:59
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

🟩 CI finished in 2h 01m: Pass: 100%/90 | Total: 2d 18h | Avg: 44m 27s | Max: 1h 24m | Hits: 57%/132225

  • 🟩 cub: Pass: 100%/44 | Total: 1d 16h | Avg: 55m 48s | Max: 1h 24m | Hits: 51%/52320 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  1d 14h | Avg: 55m 36s | Max:  1h 24m | Hits:  51%/49888 
  🟩 arm64              Pass: 100%/2   | Total:  1h 59m | Avg: 59m 55s | Max:  1h 02m | Hits:  45%/2432  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  5h 02m | Avg:  1h 00m | Max:  1h 06m | Hits:  41%/5914  
  🟩 12.5               Pass: 100%/2   | Total:  2h 31m | Avg:  1h 15m | Max:  1h 18m | Hits:  18%/2250  
  🟩 12.8               Pass: 100%/37  | Total:  1d 09h | Avg: 54m 05s | Max:  1h 24m | Hits:  54%/44156 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 59m | Avg: 59m 39s | Max:  1h 00m | Hits:  82%/2104  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  5h 02m | Avg:  1h 00m | Max:  1h 06m | Hits:  41%/5914  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 31m | Avg:  1h 15m | Max:  1h 18m | Hits:  18%/2250  
  🟩 nvcc12.8           Pass: 100%/35  | Total:  1d 07h | Avg: 53m 46s | Max:  1h 24m | Hits:  53%/42052 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 59m | Avg: 59m 39s | Max:  1h 00m | Hits:  82%/2104  
  🟩 nvcc               Pass: 100%/42  | Total:  1d 14h | Avg: 55m 37s | Max:  1h 24m | Hits:  50%/50216 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  3h 45m | Avg: 56m 15s | Max:  1h 00m | Hits:  70%/4872  
  🟩 Clang15            Pass: 100%/2   | Total:  1h 55m | Avg: 57m 46s | Max: 58m 52s | Hits:  73%/2432  
  🟩 Clang16            Pass: 100%/2   | Total:  1h 51m | Avg: 55m 33s | Max: 57m 02s | Hits:  71%/2432  
  🟩 Clang17            Pass: 100%/2   | Total:  1h 49m | Avg: 54m 33s | Max: 55m 23s | Hits:  70%/2432  
  🟩 Clang18            Pass: 100%/7   | Total:  5h 38m | Avg: 48m 21s | Max:  1h 00m | Hits:  83%/8184  
  🟩 GCC7               Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 05m | Hits:  22%/2436  
  🟩 GCC8               Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m | Hits:  22%/1218  
  🟩 GCC9               Pass: 100%/2   | Total:  2h 07m | Avg:  1h 03m | Max:  1h 05m | Hits:  22%/2436  
  🟩 GCC10              Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 07m | Hits:  22%/2436  
  🟩 GCC11              Pass: 100%/2   | Total:  2h 13m | Avg:  1h 06m | Max:  1h 08m | Hits:  22%/2432  
  🟩 GCC12              Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 03m | Hits:  22%/2432  
  🟩 GCC13              Pass: 100%/10  | Total:  6h 32m | Avg: 39m 15s | Max:  1h 04m | Hits:  60%/12160 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 25m | Avg:  1h 12m | Max:  1h 19m | Hits:  15%/2084  
  🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 46m | Avg:  1h 23m | Max:  1h 24m | Hits:  16%/2084  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 31m | Avg:  1h 15m | Max:  1h 18m | Hits:  18%/2250  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 14h 59m | Avg: 52m 53s | Max:  1h 00m | Hits:  76%/20352 
  🟩 GCC                Pass: 100%/21  | Total: 18h 12m | Avg: 52m 01s | Max:  1h 08m | Hits:  40%/25550 
  🟩 MSVC               Pass: 100%/4   | Total:  5h 12m | Avg:  1h 18m | Max:  1h 24m | Hits:  16%/4168  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 31m | Avg:  1h 15m | Max:  1h 18m | Hits:  18%/2250  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 55m 01s | Avg: 27m 30s | Max: 29m 56s | Hits:  60%/2432  
  🟩 rtx2080            Pass: 100%/34  | Total:  1d 11h | Avg:  1h 03m | Max:  1h 24m | Hits:  42%/40160 
  🟩 rtxa6000           Pass: 100%/8   | Total:  4h 14m | Avg: 31m 45s | Max:  1h 00m | Hits:  86%/9728  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 14h | Avg:  1h 02m | Max:  1h 24m | Hits:  42%/43808 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 21m 57s | Avg: 21m 57s | Max: 21m 57s | Hits:  99%/1216  
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 24s | Avg: 18m 24s | Max: 18m 24s | Hits:  99%/1216  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 13m | Avg: 24m 38s | Max: 25m 52s | Hits:  99%/3648  
  🟩 TestGPU            Pass: 100%/2   | Total: 45m 27s | Avg: 22m 43s | Max: 23m 40s | Hits:  99%/2432  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 55m 01s | Avg: 27m 30s | Max: 29m 56s | Hits:  60%/2432  
  🟩 90;90a;100         Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m | Hits:  22%/1216  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 21h 09m | Avg:  1h 03m | Max:  1h 22m | Hits:  39%/23559 
  🟩 20                 Pass: 100%/24  | Total: 19h 45m | Avg: 49m 24s | Max:  1h 24m | Hits:  61%/28761

  • 🟩 thrust: Pass: 100%/43 | Total: 1d 01h | Avg: 35m 03s | Max: 1h 12m | Hits: 60%/79625 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 44m 07s | Avg: 22m 03s | Max: 33m 15s | Hits:  68%/3706  
🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total:  1d 00h | Avg: 35m 12s | Max:  1h 12m | Hits:  60%/75920 
  🟩 arm64              Pass: 100%/2   | Total:  1h 04m | Avg: 32m 02s | Max: 37m 24s | Hits:  59%/3705  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 11m | Avg: 38m 13s | Max:  1h 01m | Hits:  59%/9256  
  🟩 12.5               Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 12m | Hits:   0%/3704  
  🟩 12.8               Pass: 100%/36  | Total: 19h 34m | Avg: 32m 37s | Max:  1h 06m | Hits:  64%/66665 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 50m 35s | Avg: 25m 17s | Max: 26m 44s | Hits:  86%/3704  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 11m | Avg: 38m 13s | Max:  1h 01m | Hits:  59%/9256  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 12m | Hits:   0%/3704  
  🟩 nvcc12.8           Pass: 100%/34  | Total: 18h 44m | Avg: 33m 03s | Max:  1h 06m | Hits:  62%/62961 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 50m 35s | Avg: 25m 17s | Max: 26m 44s | Hits:  86%/3704  
  🟩 nvcc               Pass: 100%/41  | Total:  1d 00h | Avg: 35m 31s | Max:  1h 12m | Hits:  59%/75921 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  1h 51m | Avg: 27m 46s | Max: 29m 41s | Hits:  85%/7408  
  🟩 Clang15            Pass: 100%/2   | Total: 57m 20s | Avg: 28m 40s | Max: 29m 02s | Hits:  82%/3704  
  🟩 Clang16            Pass: 100%/2   | Total: 54m 47s | Avg: 27m 23s | Max: 28m 13s | Hits:  86%/3704  
  🟩 Clang17            Pass: 100%/2   | Total: 57m 47s | Avg: 28m 53s | Max: 30m 26s | Hits:  82%/3704  
  🟩 Clang18            Pass: 100%/7   | Total:  2h 34m | Avg: 22m 00s | Max: 31m 07s | Hits:  88%/12964 
  🟩 GCC7               Pass: 100%/2   | Total:  1h 12m | Avg: 36m 06s | Max: 36m 18s | Hits:  52%/3706  
  🟩 GCC8               Pass: 100%/1   | Total: 35m 31s | Avg: 35m 31s | Max: 35m 31s | Hits:  36%/1853  
  🟩 GCC9               Pass: 100%/2   | Total:  1h 13m | Avg: 36m 32s | Max: 36m 35s | Hits:  50%/3706  
  🟩 GCC10              Pass: 100%/2   | Total:  1h 21m | Avg: 40m 34s | Max: 41m 22s | Hits:  36%/3706  
  🟩 GCC11              Pass: 100%/2   | Total:  1h 16m | Avg: 38m 26s | Max: 40m 56s | Hits:  36%/3706  
  🟩 GCC12              Pass: 100%/2   | Total:  1h 24m | Avg: 42m 26s | Max: 43m 16s | Hits:  36%/3706  
  🟩 GCC13              Pass: 100%/8   | Total:  3h 44m | Avg: 28m 00s | Max: 41m 55s | Hits:  63%/14824 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 01m | Hits:  35%/3692  
  🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 39m | Avg: 53m 08s | Max:  1h 06m | Hits:  35%/5538  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 12m | Hits:   0%/3704  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  7h 15m | Avg: 25m 35s | Max: 31m 07s | Hits:  86%/31484 
  🟩 GCC                Pass: 100%/19  | Total: 10h 47m | Avg: 34m 05s | Max: 43m 16s | Hits:  50%/35207 
  🟩 MSVC               Pass: 100%/5   | Total:  4h 42m | Avg: 56m 34s | Max:  1h 06m | Hits:  35%/9230  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 21m | Avg:  1h 10m | Max:  1h 12m | Hits:   0%/3704  
🟩 gpu
  🟩 rtx2080            Pass: 100%/33  | Total: 20h 55m | Avg: 38m 02s | Max:  1h 12m | Hits:  56%/61112 
  🟩 rtx4090            Pass: 100%/10  | Total:  4h 11m | Avg: 25m 10s | Max:  1h 06m | Hits:  75%/18513 
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 23h 47m | Avg: 38m 35s | Max:  1h 12m | Hits:  55%/68516 
  🟩 TestCPU            Pass: 100%/3   | Total: 46m 29s | Avg: 15m 29s | Max: 30m 17s | Hits:  89%/5551  
  🟩 TestGPU            Pass: 100%/3   | Total: 32m 50s | Avg: 10m 56s | Max: 11m 50s | Hits:  99%/5558  
🟩 sm
  🟩 90;90a;100         Pass: 100%/1   | Total: 41m 55s | Avg: 41m 55s | Max: 41m 55s | Hits:  42%/1853  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 13h 04m | Avg: 39m 14s | Max:  1h 09m | Hits:  53%/37031 
  🟩 20                 Pass: 100%/21  | Total: 11h 18m | Avg: 32m 18s | Max:  1h 12m | Hits:  66%/38888

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 8m 10s | Avg: 4m 05s | Max: 5m 41s | Hits: 97%/280 

    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  5m 41s | Hits:  97%/280   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 29s | Avg:  2m 29s | Max:  2m 29s | Hits:  97%/140   
  🟩 Test               Pass: 100%/1   | Total:  5m 41s | Avg:  5m 41s | Max:  5m 41s | Hits:  98%/140

  • 🟩 python: Pass: 100%/1 | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 30m 18s | Avg: 30m 18s | Max: 30m 18s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 90)
# Runner
65 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1
1 linux-amd64-gpu-h100-latest-1

@miscco miscco merged commit 61bda15 into NVIDIA:main Feb 7, 2025
104 of 106 checks passed
@bernhardmgruber bernhardmgruber deleted the drop_cpp_compat branch February 7, 2025 19:10
shwina pushed a commit to shwina/cccl that referenced this pull request Feb 10, 2025
@bernhardmgruber @shwina
Drop Thrust's cpp_compatibility.h (NVIDIA#3746)
9020216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miscco miscco miscco approved these changes

@griwes griwes Awaiting requested review from griwes griwes is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees

No one assigned

Labels

breaking Breaking change thrust For all items related to Thrust.

Projects

CCCL
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernhardmgruber @miscco