KEMBAR78
Add multi-dimensional support to block_merge_sort.merge_sort_keys() by tpn · Pull Request #4028 · NVIDIA/cccl · GitHub
Skip to content

Add multi-dimensional support to block_merge_sort.merge_sort_keys() #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Add multi-dimensional support to block_merge_sort.merge_sort_keys() #4028

merged 2 commits into from
Mar 13, 2025

Conversation

@tpn
Copy link
Contributor

@tpn tpn commented Mar 6, 2025

Per @brycelelbach's earlier work in #3161.

@tpn tpn self-assigned this Mar 6, 2025
@tpn tpn requested a review from a team as a code owner March 6, 2025 00:52
@tpn tpn requested a review from shwina March 6, 2025 00:52
@github-project-automation github-project-automation bot moved this to Todo in CCCL Mar 6, 2025
@tpn tpn moved this from Todo to In Progress in CCCL Mar 6, 2025
@tpn tpn added the 3.0 Targeted for 3.0 release label Mar 6, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Mar 6, 2025
@tpn tpn linked an issue Mar 6, 2025 that may be closed by this pull request
[FEA]: Support multidimensional thread blocks in block_merge_sort #4027
Closed
1 task
@tpn tpn requested a review from brycelelbach March 6, 2025 00:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

🟩 CI finished in 1h 01m: Pass: 100%/1 | Total: 1h 01m | Avg: 1h 01m | Max: 1h 01m

  • 🟩 python: Pass: 100%/1 | Total: 1h 01m | Avg: 1h 01m | Max: 1h 01m

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
CUDA Experimental
+/- python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
CUDA Experimental
+/- python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 1)
# Runner
1 linux-amd64-gpu-rtx2080-latest-1

This was referenced Mar 6, 2025
Merged
Merged
@tpn tpn force-pushed the 4027-multidim-block_merge_sort branch from 2c15677 to e6b4495 Compare March 13, 2025 06:30
@github-actions
Copy link
Contributor

🟩 CI finished in 1h 04m: Pass: 100%/1 | Total: 1h 04m | Avg: 1h 04m | Max: 1h 04m

  • 🟩 python: Pass: 100%/1 | Total: 1h 04m | Avg: 1h 04m | Max: 1h 04m

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
CUDA Experimental
+/- python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
CUDA Experimental
+/- python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 1)
# Runner
1 linux-amd64-gpu-rtx2080-latest-1

@tpn tpn merged commit 3fa133d into NVIDIA:main Mar 13, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Mar 13, 2025
davebayer pushed a commit to davebayer/cccl that referenced this pull request Apr 7, 2025
@tpn @davebayer
Add multi-dimensional support to block_merge_sort.merge_sort_keys() (N…
ab40947 
…VIDIA#4028)

* Add typing to numba_type_to_wrapper().

* Add multi-dimensional support to block_merge_sort.merge_sort_keys().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwina shwina shwina approved these changes

@brycelelbach brycelelbach Awaiting requested review from brycelelbach

Assignees

@tpn tpn

Labels

3.0 Targeted for 3.0 release

Projects

CCCL
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA]: Support multidimensional thread blocks in block_merge_sort

2 participants

@tpn @shwina