Improved support for kernel return values #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
force-pushed
the
ch-return.value
branch
from
58c7c9e to
6363663
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Round out the implementation of kernels that return values in the IR and carry that through to LLVM code generation (QIR). This extends the support for scalar numeric return values to include aggregate types. It also fixes some bugs, particularly with dynamically sized aggregate return values. The principle changes are to GenKernelExecution, which now uses the sret convention to return aggregate values. This actually simplifies the generation of the thunk code since the sret buffer is preallocated and can be passed by pointer rather than having the thunk copy return values itself. Add a regression test for !cc.stdvec, !cc.struct, !cc.array, and multiple return values.
schweitzpgi
force-pushed
the
ch-return.value
branch
from
cb8ab31 to
9a591c4
Compare
schweitzpgi
force-pushed
the
ch-return.value
branch
from
9a591c4 to
99f6d3c
Compare
bettinaheim
added
the
release notes
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round out the implementation of kernels that return values in the IR and carry that through to LLVM code generation (QIR). This extends the support for scalar numeric return values to include aggregate types. It also fixes some bugs, particularly with dynamically sized aggregate return values.
The principle changes are to GenKernelExecution, which now uses the sret convention to return aggregate values. This actually simplifies the generation of the thunk code since the sret buffer is preallocated and can be passed by pointer rather than having the thunk copy return values itself.
Add a regression test for !cc.stdvec, !cc.struct, !cc.array, and multiple return values.