Partial support for passing/return POD struct values. #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
force-pushed
the
ch-struct.1
branch
from
b6ec090 to
da4e83c
Compare
schweitzpgi
requested review from
amccaskey,
bettinaheim and
bmhowe23
as code owners
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
force-pushed
the
ch-struct.1
branch
2 times, most recently
from
5404fd9 to
27bfe1f
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
reviewed
Dec 21, 2023
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
reviewed
Dec 27, 2023
There is more to do here. Most notably the bridge doesn't support the ctors and other AST artifacts needed to build struct values, pass them around, etc. Supports a POD struct if it is created by some external at this point. Burned by touching an old file. Spelling checker started to whine. Change the spelling check script to deal with doxygen better. Fix LLVM code gen bug.
schweitzpgi
force-pushed
the
ch-struct.1
branch
from
32c9c80 to
537c433
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more to do here. Most notably the bridge doesn't support the ctors and other AST artifacts needed to build struct values, pass them around, etc.
Supports a POD struct if it is created by some external at this point.