KEMBAR78
Support for arguments that are compositions of vectors and structures by schweitzpgi · Pull Request #1080 · NVIDIA/cuda-quantum · GitHub
Skip to content

Support for arguments that are compositions of vectors and structures #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2024
Merged

Support for arguments that are compositions of vectors and structures #1080

merged 3 commits into from
Jan 30, 2024
+592 −160

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Jan 10, 2024 •
edited by bettinaheim
Loading

Add test for struct of struct members, struct with vector members and vector of struct type arguments.
Second half of the changes in #1267.

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
ae9f908
@schweitzpgi schweitzpgi requested a review from amccaskey January 10, 2024 17:22
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
2680750
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
3e59f4d
@schweitzpgi schweitzpgi force-pushed the ch-struct.5 branch 2 times, most recently from ad38b6b to 82dba5c Compare January 22, 2024 17:08
@schweitzpgi
Copy link
Collaborator Author

ping for review

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
98db267
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
e7376b0
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
8995afa
amccaskey
amccaskey approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
d16ccb9
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 25, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
48045e1
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 26, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
7372cc1
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 26, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
b655000
@schweitzpgi
Part 1: Start adding support for arguments that are compositions
a71b6ee 
of vectors and structures.

Add test for struct of struct members, struct with vector
members and vector of struct type arguments.
@schweitzpgi
Add standard option to fake out the CI.
585beb4
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
5c3730a
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
904101a
@schweitzpgi schweitzpgi enabled auto-merge (squash) January 29, 2024 21:50
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
@cuda-quantum-bot
Docs preview for PR #1080.
3520010
@schweitzpgi schweitzpgi merged commit b8032d5 into NVIDIA:main Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@schweitzpgi schweitzpgi deleted the ch-struct.5 branch January 30, 2024 19:16
@schweitzpgi schweitzpgi added this to the release 0.7.0 milestone Jan 31, 2024
@bettinaheim bettinaheim changed the title Part 1: Start adding support for arguments that are compositions Support for arguments that are compositions of vectors and structures - Part 1 Mar 9, 2024
@bettinaheim bettinaheim added the enhancement New feature or request label Mar 9, 2024
@bettinaheim bettinaheim changed the title Support for arguments that are compositions of vectors and structures - Part 1 Support for arguments that are compositions of vectors and structures Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amccaskey amccaskey amccaskey approved these changes

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

release 0.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schweitzpgi @amccaskey @bettinaheim