Miscellaneous bug fixes for argument and return values #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganize and add more end-to-end tests for passing arguments and returning result values. The tests include cases that are not yet implemented. Those cases are inactive until implemented. - Fix bug with sret returns. - Fix bugs with small struct ABI passing on C++ side. TODO: it would be better to use the clang backend code, but it is not exported. - Fix bug in vector result return handler. - Fix GKE to handle argument register pairs (needed for small struct) - Fix bug with multi-result kernels - Corrections made to tests for changes.
backquoting failed.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Mar 3, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize and add more end-to-end tests for passing arguments and returning result values. The tests include cases that are not yet implemented. Those cases are inactive until implemented.
Fix bug with sret returns.
Fix bugs with small struct ABI passing on C++ side. TODO: it would be better to use the clang backend code, but it is not exported.
Fix bug in vector result return handler.
Fix GKE to handle argument register pairs (needed for small struct)
Fix bug with multi-result kernels
Corrections made to tests for changes.