KEMBAR78
Adds the ability to pass vector<bool> values to kernels as input by schweitzpgi · Pull Request #1404 · NVIDIA/cuda-quantum · GitHub
Skip to content

Adds the ability to pass vector<bool> values to kernels as input #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2024
Merged

Adds the ability to pass vector<bool> values to kernels as input #1404

merged 4 commits into from
Mar 18, 2024

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Mar 14, 2024 •
edited by bettinaheim
Loading

No description provided.

@schweitzpgi schweitzpgi requested a review from 1tnguyen March 14, 2024 23:29
@schweitzpgi schweitzpgi enabled auto-merge (squash) March 14, 2024 23:36
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@cuda-quantum-bot
Docs preview for PR #1404.
ce498f7
@schweitzpgi schweitzpgi disabled auto-merge March 15, 2024 00:13
@schweitzpgi schweitzpgi enabled auto-merge (squash) March 15, 2024 01:18
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@cuda-quantum-bot
Docs preview for PR #1404.
61ccfab
@schweitzpgi schweitzpgi force-pushed the ch-handle.vector.bool.input branch from fa8b320 to e77639a Compare March 15, 2024 15:22
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@cuda-quantum-bot
Docs preview for PR #1404.
05de0e7
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@cuda-quantum-bot
Docs preview for PR #1404.
354fae7
1tnguyen
1tnguyen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested by using this patch in the remote-mqpu argument tests.

@schweitzpgi schweitzpgi merged commit ae96571 into NVIDIA:main Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@schweitzpgi schweitzpgi deleted the ch-handle.vector.bool.input branch March 21, 2024 17:40
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
@bettinaheim bettinaheim changed the title Adds: the ability to pass vector<bool> values to kernels as input. Adds the ability to pass vector<bool> values to kernels as input Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

Assignees

No one assigned

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Milestone

release 0.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@schweitzpgi @1tnguyen @bettinaheim